Skip to content
This repository has been archived by the owner on Sep 6, 2021. It is now read-only.

Code cleanup: Consistent naming for CSS classes/IDs #408

Closed
njx opened this issue Mar 6, 2012 · 4 comments
Closed

Code cleanup: Consistent naming for CSS classes/IDs #408

njx opened this issue Mar 6, 2012 · 4 comments
Assignees
@redmunds
Labels
code cleanup low priority

Comments

@njx
Copy link
Member

njx commented Mar 6, 2012

Currently in we have a mix of CSS classes/ids named with hyphens (e.g. .dummy-text) and named in camel-case (e.g. .inlineCodeEditor). We should have a consistent style for these.
@njx
Copy link
Member Author

njx commented Mar 20, 2012

QRB reviewed. Marking code cleanup.

@redmunds
Copy link
Contributor

We also need to review the style sheet structure. We currently have a mixture of overlapping organizational patterns:

  • by Framework (brackets_codemirror_override.less)
  • by component (jsTreeTheme.less)
  • by LESS functional type (brackets_variables.less)
  • by presentational type (brackets_colors.less)

@njx
Copy link
Member Author

njx commented May 8, 2012

Assigning to Randy. Let's go with hyphens for everything, including mixins and variable names.

@ghost ghost assigned redmunds May 8, 2012
@redmunds redmunds mentioned this issue May 9, 2012
Merged
jasonsanjose added a commit that referenced this issue May 9, 2012
@jasonsanjose
Merge pull request #846 from adobe/randy/cleanup-style-names
7240964 
Issue #408 - cleanup style names
@ghost ghost assigned njx and redmunds May 10, 2012
@redmunds
Copy link
Contributor

There's really nothing to confirm, so closing.

sedge added a commit to sedge/nimble that referenced this issue Aug 19, 2015
@sedge
Fixed adobe#408 - Add a production branch for auto prod deploys
83afe1d
sedge added a commit to sedge/nimble that referenced this issue Aug 19, 2015
@sedge
Fixed adobe#408 - Add a production branch for auto prod deploys
8485735
gideonthomas pushed a commit to gideonthomas/brackets that referenced this issue Oct 1, 2015
@sedge
Fixed adobe#408 - Add a production branch for auto prod deploys
65021c8
@core-ai-bot core-ai-bot mentioned this issue Aug 29, 2021
Open
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@redmunds redmunds

Labels
code cleanup low priority
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@njx @redmunds