Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

[CEF 1750] Menu unit test failures in CEF 3.1650.1539 #6378

Closed
jasonsanjose opened this Issue · 14 comments

4 participants

Jason San Jose Narciso Jaramillo Jeff Booher Peter Flynn
Jason San Jose
Owner

See comments in adobe/brackets-shell#403. Specifically...

So, it appears that test window is not redrawing after ContextMenu.open() here

        $menuAnchor.addClass("open")
                   .css({"left": posLeft, "top": posTop});

If in the unit test I force a layout by accessing offset properties (or jQuery .offset()), the context menu appears as desired. I'm not sure why this doesn't manifest in the main window though. Seems like a potential blocker if we find layout issues in the main window.

Jeff Booher JeffryBooher was assigned
Narciso Jaramillo
Owner
njx commented

Moving to medium priority (from high priority), since this isn't in the actual build yet and we're not planning to merge the new CEF this sprint.

Jason San Jose jasonsanjose was assigned
Jason San Jose
Owner

Moved to sprint 37. Too late to take for sprint 36.

Jeff Booher
Collaborator

Confirmed fixed in CEF 3.1768.1579 (Chromium 34.0.1768.0 r242756). However, there are a few API changes and there is no more getDevToolsUrl API but the popup window version now works.

Moving this issue to Track until CEF 3.1768 makes it to CEF Stable since 1579 is in the Dev trunk.

Removing Sprint 37 -- tracking for CEF 3.1768 makes its way into stable branch.

Jeff Booher JeffryBooher was assigned
Peter Flynn
Owner

@JeffryBooher Fwiw I believe @gruehle had a plan for what to do about the getDevToolsUrl() API going away (there's now some way to launch dev tools within the brackets-shell process itself).

Jeff Booher
Collaborator

Works pretty good on Windows

image

Jeff Booher
Collaborator

There is a crash in ClientHandler::OnPreKeyEvent which will take some digging into to figure out. The debug version still does not work but If I comment out that block of code and return false it works but won't translate any of the accelerators.

Jason San Jose

Hey @JeffryBooher, here adobe/brackets-shell#403 (comment) you mention the bug is fixed in 33.0.1750.35. Earlier in this thread you mentioned a newer 3.1768 branch instead.

Is there a reason to jump over 1750 to 1768? The current 1750 branch on cefbuilds.com is at 33.0.1750.58.

Jeff Booher
Collaborator

@jasonsanjose 1750 wasn't up when I wrote that post -- the earliest build with a version > Chrome 31 at the time was in the dev trunk (3.1768) which had Chrome 34. 1750 is on chrome 33 which I did not test because it wasn't available for testing at the time but I was able to confirm that it was fixed in chrome 34.0.1768.0 r242756.

I will test the 3.1750.1625 build of cef to see if it is fixed with that version of chromium but I won't be able to get to until tomorrow and sprint 37 ends soon so the earliest it will go in will be sprint 38.

Jason San Jose

Makes sense. Thanks for the update!

Jeff Booher
Collaborator

Thanks for staying on top of the cef builds. I was heads down on other stuff and hadn't noticed there was a new build.

Narciso Jaramillo njx added this to the Release #41 milestone
Narciso Jaramillo njx changed the title from Menu unit test failures in CEF 3.1650.1539 to [CEF 1750] Menu unit test failures in CEF 3.1650.1539
Narciso Jaramillo
Owner
njx commented

Tagging [CEF 1750] and marking FBNC for Release 41 (since we want to verify that this is fixed in the 1750 branch). @JeffryBooher can you confirm that this is fixed in the current CEF 1750 branch?

Jeff Booher
Collaborator

Confirmed that all menu tests pass on Windows. FBNC @jasonsanjose

Jeff Booher JeffryBooher removed their assignment
Jeff Booher
Collaborator

Amending that with they pass on Mac as Well.

Jason San Jose
Owner

Confirmed fixed on mac. Closing.

Peter Thiess pthiess referenced this issue
Closed

Integrate CEF 2171 (Chrome 39) -- pending items #9089

5 of 5 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.