Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP

Loading…

Remove deprecated CollectionUtils module #6403

Closed
peterflynn opened this Issue · 8 comments

4 participants

@peterflynn
Owner

It looks like commit 7b40ba8 removed the last reference to CollectionUtils from Brackets core. This means that any extensions using the module will fail to load since the brackets.getModule() call will fail.
(Edit: we restored the reference for now (2nd bullet below), and this bug is now just tracking the remaining work to fully remove it later once extensions have had more time to migrate)

CollectionUtils contains only deprecated methods, so this needs to happen sooner or later anyway. But we should cleanly either:

  • Fully desupport it now -- still need to delete the module from the source tree, and perhaps file bugs on extensions that will break as a result (it broke 4 of mine, for example)
  • Continue to support the deprecated APIs a bit longer -- need to add a require() reference in brackets.js to ensure the module is accessible to extensions
@peterflynn
Owner

Assigning to Sprint 36 since we should make a decision about this before the sprint goes out the door

@peterflynn peterflynn was assigned
@peterflynn
Owner

For now we're going to keep the module available, but I'll go file bugs against any extensions still using it so we can remove it in the near future (Sprint 37?).

@njx
Owner

@peterflynn - this was assigned to Sprint 37, but it seems like we have to do a bit of work in Sprint 36 (adding the reference in brackets.js) in order to keep it working, right? It doesn't look like that got done yet, so putting this back in Sprint 36 so we remember to do it.

@redmunds
Collaborator

@peterflynn Should this Milestone now be moved to Sprint 37?

@peterflynn
Owner

@redmunds You mean turn it into a bug tracking the final removal of the API? That seems fair, though I don't know if it needs any milestone in particular in that case. I'll make the adjustment.

@redmunds
Collaborator

Removed Sprint 36 Milestone.

@peterflynn
Owner

Changed title (was: "CollectionUtils is no longer usable by extensions") and reduced priority -- changing this into an issue tracking the eventual removal of the module for good.

@dangoor
Collaborator

#8960 removed CollectionUtils.

@dangoor dangoor closed this
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.