Intermittent odd behavior when closing an inline editor #6418

Closed
njx opened this Issue Jan 8, 2014 · 11 comments

Projects

None yet

4 participants

@njx
Member
njx commented Jan 8, 2014
  1. Open citrus completed
  2. On line 17, put the cursor after <a
  3. Cmd-E to open the inline editor
  4. Hit Esc to close it
  5. Do steps 3 and 4 a couple of times

Results:

  • Sometimes when hitting Esc, the editor closes, opens, then closes again.
  • Sometimes, if you look at the bottom of the screen while the editor is closing, the area is blank and then redraws instead of just scrolling the lower lines onto the screen.

This doesn't appear to be a regression in the most recent CodeMirror merge - I can repro it in the commit right before it.

@njx njx was assigned Jan 8, 2014
@njx
Member
njx commented Jan 8, 2014

Also, the blank-at-bottom issue seems to be more obvious when opening a large Quick Docs item (e.g. "background") in a long CSS file.

@RaymondLim
Collaborator

@njx I can reproduce it only when I hit Esc immediately before inline Editor animation is done in step 3.

@njx
Member
njx commented Jan 8, 2014

I think I can repro even if I wait a bit, but it does seem likely to be a race condition of some kind. That doesn't really explain the "blank lines at bottom" issue, although that's probably also related to the animation timing.

@RaymondLim
Collaborator

I have another scenario that can cause the page to scroll to the bottom and won't let you scroll back to the top of the page. But you need to have a css file like dropzone.css in your project. Once that css is in your project sometimes opening the inline editor on any tag will show up css code from dropzone.css. And if you dismiss the inline quickly, then the hair cursor in the main editor is set to a line in the bottom portion of the page and you won't be able to scroll up.

Update: dropzone.css has to be the minified version and you have to dismiss the inline quickly to see it on mac. I pressed Cmd-E twice to reproduce it consistently.

@njx
Member
njx commented Jan 8, 2014

That sounds bad. Does it repro before the latest CM merge?

@RaymondLim
Collaborator

Yes, it does reproduce even without the latest CM merge.

@njx
Member
njx commented Jan 13, 2014

Changing to medium priority to look at @RaymondLim's case.

@njx njx added this to the Brackets 1.0 milestone Mar 15, 2014
@njx
Member
njx commented Mar 15, 2014

Nominating for 1.0.

@dangoor
dangoor commented Apr 23, 2014

Reviewed. Keeping for 1.0 to investigate the issues and figure out how important/difficult to fix they are (and if the problems still exist with CMv4)

@njx njx added the F Quick Edit label Jul 10, 2014
@njx njx removed their assignment Jul 10, 2014
@njx
Member
njx commented Jul 10, 2014

Reassigning to @RaymondLim - feel free to reassign

@RaymondLim RaymondLim self-assigned this Jul 10, 2014
@RaymondLim
Collaborator

@njx I'll be closing this since I can't reproduce the odd behavior in the master anymore and I believe changes in CMv4 or later have fixed the scrolling or rendering issue.

@RaymondLim RaymondLim closed this Jul 10, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment