Skip to content
This repository has been archived by the owner on Sep 6, 2021. It is now read-only.

Improve handling of animations #7908

Open
njx opened this issue May 21, 2014 · 2 comments
Open

Improve handling of animations #7908

njx opened this issue May 21, 2014 · 2 comments

Comments

@njx
Copy link
Member

njx commented May 21, 2014

While looking at #7894, it occurred to me that there are several potential issues with the way we're handling animations for elements:

  • If animateUsingClass() is called twice in rapid succession (so the second call occurs before the first animation completes), we should immediately resolve the initial promise before starting the second animation, since we aren't guaranteed that we'll get a webkitTransitionEnd event for both, or when it will get sent out.
  • There's no special handling in the inline widget stuff for the case where a user closes an inline widget while it's still opening. We use PromiseQueue to make sure that multiple inline widget open animations are sequentialized, but we don't do the same for closings, it seems.
  • ModalBar opens by just attaching a class, not by using animateUsingClass(), but closes using animateUsingClass(). That might be okay since we don't need to do anything special when the open animation completes, but it could be an issue if something about the timing of the transition end event is screwy.

In general, we need to analyze the race conditions here in more detail and make sure we aren't missing something.

@njx njx self-assigned this May 21, 2014
@njx
Copy link
Member Author

njx commented May 21, 2014

To me, low priority

@TomMalbran
Copy link
Contributor

Since we have this code cleanup, I would suggest using both webkitTransitionEnd and transitionEnd to better support other Browsers.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants