You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Sep 6, 2021. It is now read-only.
While looking at #7894, it occurred to me that there are several potential issues with the way we're handling animations for elements:
If animateUsingClass() is called twice in rapid succession (so the second call occurs before the first animation completes), we should immediately resolve the initial promise before starting the second animation, since we aren't guaranteed that we'll get a webkitTransitionEnd event for both, or when it will get sent out.
There's no special handling in the inline widget stuff for the case where a user closes an inline widget while it's still opening. We use PromiseQueue to make sure that multiple inline widget open animations are sequentialized, but we don't do the same for closings, it seems.
ModalBar opens by just attaching a class, not by using animateUsingClass(), but closes using animateUsingClass(). That might be okay since we don't need to do anything special when the open animation completes, but it could be an issue if something about the timing of the transition end event is screwy.
In general, we need to analyze the race conditions here in more detail and make sure we aren't missing something.
The text was updated successfully, but these errors were encountered:
While looking at #7894, it occurred to me that there are several potential issues with the way we're handling animations for elements:
animateUsingClass()
is called twice in rapid succession (so the second call occurs before the first animation completes), we should immediately resolve the initial promise before starting the second animation, since we aren't guaranteed that we'll get awebkitTransitionEnd
event for both, or when it will get sent out.animateUsingClass()
, but closes usinganimateUsingClass()
. That might be okay since we don't need to do anything special when the open animation completes, but it could be an issue if something about the timing of the transition end event is screwy.In general, we need to analyze the race conditions here in more detail and make sure we aren't missing something.
The text was updated successfully, but these errors were encountered: