Our Travis config encourages IRC spam #8509

Closed
peterflynn opened this Issue Jul 22, 2014 · 5 comments

Comments

Projects
None yet
3 participants
Member

peterflynn commented Jul 22, 2014

The Brackets src includes a Travis config file, which among other things causes a Travis bot to send notifications to our IRC room: https://github.com/adobe/brackets/blob/master/.travis.yml#L8.

But this means that anyone who forks Brackets and registers their fork with Travis will have this same config. And anytime they push to their own private fork, it will dump notifications into the global IRC room.

Ideally we should configure it so that only the 'master' repo sends notifications to #brackets on IRC. I'm not sure how to do that, but docs are here: http://docs.travis-ci.com/user/notifications/

Member

peterflynn commented Jul 22, 2014

Hmm, actually looks like this bug covers it: travis-ci/travis-ci#329. But their current plan for a fix (move notification settings out of config file, onto Travis website) isn't implemented yet.

It looks like a specific fix was made for email spam (see travis-ci/travis-ci#1206), but not for any other notifications like IRC. So this might be a FOL for now...

Member

pthiess commented Jul 28, 2014

Travis is linking to travis-ci/travis-ci#1094 now...

Contributor

dangoor commented Jul 28, 2014

We just discussed this in bug review. My inclination is just to remove the IRC notification because I don't think it gives us much value over what we see on the pull request page on GitHub.

Leaving this open for a week to see if there is anyone who really relies on the IRC notifications.

@dangoor dangoor added this to the Release 0.43 milestone Aug 4, 2014

Contributor

dangoor commented Aug 4, 2014

Adding release milestone not because this is high priority but because someone should just do it because it's trivial.

Contributor

dangoor commented Aug 4, 2014

Removed in 35aa7a3

@dangoor dangoor closed this Aug 4, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment