EditorOptionHandler unit test failure #8519

Closed
redmunds opened this Issue Jul 22, 2014 · 4 comments

Comments

Projects
None yet
4 participants
Contributor

redmunds commented Jul 22, 2014

This was recently injected. According to git bisect it's PR #8492, commit https://github.com/MiguelCastillo/brackets/commit/3681d927b5b41beb0c5878e79312fbf53603e644

"should NOT wrap the long lines in another document when word-wrap off"

Error: Expected 165 to equal 150.
    at new jasmine.ExpectationResult (file:///C:/Users/redmunds/dev/github/brackets-shell/Release/dev/test/thirdparty/jasmine-core/jasmine.js:114:32)
    at null.toEqual (file:///C:/Users/redmunds/dev/github/brackets-shell/Release/dev/test/thirdparty/jasmine-core/jasmine.js:1235:29)
    at null.<anonymous> (file:///C:/Users/redmunds/dev/github/brackets-shell/Release/dev/test/spec/EditorOptionHandlers-test.js:103:45)
    at jasmine.Block.execute (file:///C:/Users/redmunds/dev/github/brackets-shell/Release/dev/test/thirdparty/jasmine-core/jasmine.js:1064:17)
    at jasmine.Queue.next_ (file:///C:/Users/redmunds/dev/github/brackets-shell/Release/dev/test/thirdparty/jasmine-core/jasmine.js:2096:31)
    at jasmine.Queue.start (file:///C:/Users/redmunds/dev/github/brackets-shell/Release/dev/test/thirdparty/jasmine-core/jasmine.js:2049:8)
    at jasmine.Spec.execute (file:///C:/Users/redmunds/dev/github/brackets-shell/Release/dev/test/thirdparty/jasmine-core/jasmine.js:2376:14)
    at jasmine.Queue.next_ (file:///C:/Users/redmunds/dev/github/brackets-shell/Release/dev/test/thirdparty/jasmine-core/jasmine.js:2096:31)
    at onComplete (file:///C:/Users/redmunds/dev/github/brackets-shell/Release/dev/test/thirdparty/jasmine-core/jasmine.js:2092:18)
    at jasmine.Spec.finish (file:///C:/Users/redmunds/dev/github/brackets-shell/Release/dev/test/thirdparty/jasmine-core/jasmine.js:2350:5)

It's easy to see if you do this:

Recipe:

  1. Open file test/spec/EditorOptionHandlers-test-files/test.html
  2. Turn off word wrap
  3. Place cursor at beginning of line 9

Results:
It causes last char of line to wrap

@redmunds redmunds added this to the Release 0.42 milestone Jul 22, 2014

Member

MiguelCastillo commented Jul 23, 2014

Cool man, I will take a look in a bit. I have a feeling this due to spans with inline-blocks

Contributor

TomMalbran commented Jul 23, 2014

@MiguelCastillo I just verified that it is. I commented the inline-block display and the test passed.

Contributor

redmunds commented Jul 23, 2014

Confirmed. Closing.

Contributor

dangoor commented Jul 23, 2014

This is FBNC to @redmunds

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment