4 - top of view is further down -- cursor hidden above the top
5 - cursor goes about 10 lines below where you clicked
6 - cursor goes to correct location, but view scrolls up about 1/2 line for no apparent reason
Clicking now works fine, but if I scroll by dragging the scrollbar thumb, the next two clicks will show the same problem as steps 5 & 6 again.
CC @dangoor @MiguelCastillo -- this just started happening after syncing today
I'm seeing other weird problems too:
Which of these symptoms you see at startup seems to depend either on the exact pixel alignment of the top of the viewport, or maybe just on timing. They seem to come & go, but something goes wrong almost every time I restart.
I think this was caused by #8512. This sounds like exactly the sort of bugs we used to see when the web font didn't finish loading before CM started measuring text. The .dummy-text selector in brackets.less must have the code editor webfont's font-family set on it -- which up until now it was getting via .code-font().
(An important side note from this is that theme extensions have no safe way of using other webfonts as the editor font. I think that's an ok limitation for now, but we should make sure to document it somewhere).
I can confirm that backing out that changes to .code-font() in brackets_theme_default.less fixes this
@peterflynn I am really thinking that his change isn't really needed.... Is there a quick change we can do to fix it? Otherwise we could just back the changes in the less file. The changes in the ViewCommandHandlers is needed though.
@peterflynn Can you give this a try and let me know how it goes please?
So far, in my testing #8526 fixes this.
@dangoor I'm a little skeptical that #8526 fixes this -- in my testing I wasn't clicking anywhere that would show a matching-brace highlight... and none of the conditions that required the .dummy-text workaround have changed afaik (yet we've now removed the workaround).
Also -- since this is load-timing sensitive, it may be harder to reproduce on some machines (SSD?) than others...
yeah the line height setting isn't really what's breaking this... peter try #8525 if you can. it is a time sensitive thing.
I can no longer repro this one in the #8526 branch.
@peterflynn Indeed, load timing issues could be different on different machines, so it's quite possible that the font loading change could make a difference that's not visible on my machine.
@peterflynn to verify fix
@peterflynn can you still see any of these problems at startup?
Oops, meant to close this last cycle -- definitely doesn't happen anymore