Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP

Loading…

Switching from Replace to Replace in Files clears all input fields #8531

Closed
JeffryBooher opened this Issue · 7 comments
@JeffryBooher
Collaborator
  • Open a document and invoke replace
  • Type something to replace and replacement values in the corresponding input fields NOTE: be sure the type something that isn't found in the currently opened document
  • switch to replace in files
    ==> input fields are cleared

I realized that I intended to invoke replace across files instead of just replace in the current document and switched then had to re-enter everything i had typed before. Not sure how common that is but it's definitely a nice to have.

Also occurs when switching between find and find across files.

@peterflynn
Owner

@JeffryBooher I'm only seeing the second field (replace with) getting cleared. The first field should copy over the search query value (there's specific code to do that).

Find in Files works fine for me (since only the query field is present, and that value is copied).

Could this be specific to your branch maybe? Or caused by an extension you have installed?

@JeffryBooher
Collaborator

@peterflynn do you have a selection in the document? I think it populates the search for field with whatever is selected in the document. In my case, i typed it in (or rather copied and pasted it from a web page) so it wasn't found in the current document. That's when I realized I was searching in the current document because it told me there were 0 occurrences in the current document.

@peterflynn
Owner

Aha -- good catch. So the bug only happens (a) when starting from the "in Files" variant, or (b) when the text you entered has no matches in the current document. Looks like a regression caused by the FindBar stuff that landed in 0.41.

@peterflynn peterflynn added this to the Release 0.43 milestone
@JeffryBooher JeffryBooher self-assigned this
@JeffryBooher
Collaborator

I'll take a look for the release.

@dangoor

Reviewed. Not a blocker for 0.43, but in for 0.44.

@JeffryBooher JeffryBooher was unassigned by dangoor
@pthiess pthiess added the Ready label
@dangoor dangoor added Review and removed Ready labels
@redmunds
Collaborator

FBNC to @JeffryBooher

@redmunds redmunds removed their assignment
@JeffryBooher
Collaborator

Fixed confirmed. Closing

@JeffryBooher JeffryBooher removed the Testing label
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.