Skip to content
This repository has been archived by the owner. It is now read-only.

Highlight scrollbar tickmark for the current Find match #10413

Merged
merged 1 commit into from Feb 10, 2015

Conversation

@peterflynn
Copy link
Member

@peterflynn peterflynn commented Jan 19, 2015

Highlight scrollbar tickmark for the current Find match differently from the other matches (similar to the text highlighting within the editor: the current match is orange and the other matches are yellow).

Also, fix a bug where the wrong text highlight color was seen when a file had many search results (> FIND_HIGHLIGHT_MAX) or was too big to search for all matches at once (> FIND_MAX_FILE_SIZE): ensure .CodeMirror-searching is always applied to the current-match highlight, even when other matches aren't highlighted.

I thought this would be a nice enhancement to get into 1.2 :-)

the other matches (similar to the text highlighting within the editor).

Also, fix a bug where the wrong text highlight color was seen when a file
had many search results (> FIND_HIGHLIGHT_MAX) or was too big to searhc for
all matches at once (> FIND_MAX_FILE_SIZE): ensure "CodeMirror-searching" is
always applied to the current-match highlight, even when other matches aren't
highlighted.
prksingh added a commit that referenced this issue Feb 10, 2015
Highlight scrollbar tickmark for the current Find match
@prksingh prksingh merged commit 3243e74 into master Feb 10, 2015
1 check passed
Loading
@prksingh
Copy link
Contributor

@prksingh prksingh commented Feb 10, 2015

@peterflynn Changes look good to me. This would be really useful too :) Merging for 1.2

Loading

peterflynn added a commit that referenced this issue Feb 10, 2015
…tests

to verify that search tickmarks are rendered.

Also, bump up wait time in WorkingSetView-test that was failing sporadically.
The test had zero margin for error on the wait, which may be making it fragile.
prksingh added a commit that referenced this issue Feb 11, 2015
Fix unit test that broke due to Find highlighting fix in PR #10413
@peterflynn peterflynn deleted the pflynn/find-highlight-tickmark branch Feb 12, 2015
peterflynn added a commit that referenced this issue Feb 13, 2015
…ile-system

* origin/master: (180 commits)
  Update to release 1.3
  FR and JP translation fix for index.html file
  Fix unit test that broke due to a side fix in PR #10413, and enhance tests to verify that search tickmarks are rendered.
  Only print deprecation warnings for $().on/off() on EventDispatchers once per caller, like other such warnings. Move $() shim into brackets.js normal startup code, since there's no longer any core code that could hit it (only extensions).
  Fix memory leak in ExtensionManagerViewModel
  Don't adjust selection if rename fails. Add unit tests for these cases.
  Fixed typos in docs
  Update the selected file if a renamed folder is a prefix of the path
  Use command instead of private method.
  German Translation
  Update jQuery -> 2.1.3
  Fix for ImageView bug 5960 & 10180
  Update README.md
  Update README.md
  Update translation
  Update strings.js
  Update urls.js
  Get rid of deprecated calls in LiveDevMultiBrowser
  Add missing attribute
  Fixing UX issue of inactive panel getting too dim to read text for dark themes.
  ...
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants