Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Clean up dependencies in brackets.js #10596
@MarcelGerber, it works OK. The only comment I have is: I'd also move the CodeMirror load/global def lines 104-114 to before line 47 (right before all the CodeMirror plugins are loaded). First of all, these lines create a global; secondly it makes sense (for readability) to load the module itself before loading its plugins. Tried the change, it causes no problems. Does it make sense to you?
The issue with that is, though, that these lines need
The only thing we could do is load CodeMirror before line 47 and then create the global, deprecated object afterwards, but that would then be out of context.