Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
[#10166] Highlight 'text/ng-template' (Angular) in script tags as HTML #10666
I have just signed the brackets cla.
Regarding your question, I was trying to follow the convention for the other mime types in the regex which did not include the "-template". However, on further thought, since "ng" is somewhat generic, it would probably be better to specify "ng-template" instead. I will change it soon. Thanks.
@munxtwo If you can just share what unit testing you have done that should be fine too. Having a written unit test is surely good to have, as other people can just run tests whenever some changes go in this area.
By the way our test suite is present at the following location
You can look at the JS files at this location to get an understanding of how to write tests in Brackets.
@nethip oh were you referring to the manual test cases that I have run?
I basically used the code snippet that was provided in the issue description. Here are the test cases I did: