New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Indonesian translation updates #10713

Merged
merged 13 commits into from Mar 23, 2015

Conversation

Projects
None yet
4 participants
@resir014
Contributor

resir014 commented Mar 7, 2015

The following commits contain updates to the Indonesian translation. Fixed some translations, new strings added, and the Getting Started page is also revamped to match the new version.

As always, this translation loosely follows the transliteration guidelines provided here: http://www.vlsm.org/etc/baku-0.txt

@nethip

This comment has been minimized.

Show comment
Hide comment
@nethip

nethip Mar 16, 2015

Contributor

@resir014 Could you add some one who can do a linguistic review on this PR?

Contributor

nethip commented Mar 16, 2015

@resir014 Could you add some one who can do a linguistic review on this PR?

@yolapop

This comment has been minimized.

Show comment
Hide comment
@yolapop

yolapop Mar 16, 2015

Contributor

@nethip Hi, is it okay if I review this translation? (But I'm not a linguist, unfortunately we don't really know any linguist here.. or if you really need a linguist, maybe that should be the requirement upfront)

Contributor

yolapop commented Mar 16, 2015

@nethip Hi, is it okay if I review this translation? (But I'm not a linguist, unfortunately we don't really know any linguist here.. or if you really need a linguist, maybe that should be the requirement upfront)

@prksingh

This comment has been minimized.

Show comment
Hide comment
@prksingh

prksingh Mar 17, 2015

Contributor

@yolapop Please go ahead and review. By linguistic review, I think he was expecting a 'language specific' review and not a code review. Don't need a linguist to review this. Thanks

Contributor

prksingh commented Mar 17, 2015

@yolapop Please go ahead and review. By linguistic review, I think he was expecting a 'language specific' review and not a code review. Don't need a linguist to review this. Thanks

@resir014

This comment has been minimized.

Show comment
Hide comment
@resir014

resir014 Mar 17, 2015

Contributor

@prksingh Okay, @yolapop's already working on it and I'll merge their changes into this PR when we're ready.

Contributor

resir014 commented Mar 17, 2015

@prksingh Okay, @yolapop's already working on it and I'll merge their changes into this PR when we're ready.

yolapop and others added some commits Mar 19, 2015

Update strings.js
Seems like your string is not equal with https://raw.githubusercontent.com/adobe/brackets/master/src/nls/root/strings.js. (Mine is).

Major changes, especially "berkas" which was changed into "file".
Reasons:
1) Most people don't know what "berkas" means in the digital sense (although I use "berkas" in academic stuff)
2) Google Chrome uses "file" too

For maximum consistensy, please re-review again
@resir014

This comment has been minimized.

Show comment
Hide comment
@resir014

resir014 Mar 23, 2015

Contributor

@nethip @prksingh Okay, our review is done and we've pushed our changes.

Contributor

resir014 commented Mar 23, 2015

@nethip @prksingh Okay, our review is done and we've pushed our changes.

@prksingh

This comment has been minimized.

Show comment
Hide comment
@prksingh

prksingh Mar 23, 2015

Contributor

@resir014 @yolapop Thanks. Merging.

Contributor

prksingh commented Mar 23, 2015

@resir014 @yolapop Thanks. Merging.

prksingh added a commit that referenced this pull request Mar 23, 2015

@prksingh prksingh merged commit 2d880bc into adobe:master Mar 23, 2015

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment