New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update strings.js for HR(croatian) #10736

Merged
merged 1 commit into from Mar 17, 2015

Conversation

Projects
None yet
4 participants
@diomed
Contributor

diomed commented Mar 12, 2015

updates for Croatian language

@nethip nethip changed the title from Update strings.js to Update strings.js for HR(croatian) Mar 16, 2015

@nethip

This comment has been minimized.

Show comment
Hide comment
@nethip

nethip Mar 16, 2015

Contributor

Change the title to reflect the what this PR actually does.

@diomed Could you add some one you could do a linguistic review of this PR?

Contributor

nethip commented Mar 16, 2015

Change the title to reflect the what this PR actually does.

@diomed Could you add some one you could do a linguistic review of this PR?

@diomed

This comment has been minimized.

Show comment
Hide comment
@diomed

diomed Mar 16, 2015

Contributor

no, I don't know anyone personally who uses github. and I believe there were no complaints to my translation yet. I am "official" translator for this. Did most of it on my own. What I don't know I leave it in english, and what I do I translate it correctly, in the spirit of my language, so everyone could understand.

Contributor

diomed commented Mar 16, 2015

no, I don't know anyone personally who uses github. and I believe there were no complaints to my translation yet. I am "official" translator for this. Did most of it on my own. What I don't know I leave it in english, and what I do I translate it correctly, in the spirit of my language, so everyone could understand.

prksingh added a commit that referenced this pull request Mar 17, 2015

Merge pull request #10736 from diomed/patch-1
Update strings.js for HR(croatian)

@prksingh prksingh merged commit 65b44d2 into adobe:master Mar 17, 2015

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@prksingh

This comment has been minimized.

Show comment
Hide comment
@prksingh

prksingh Mar 17, 2015

Contributor

Merging.

Contributor

prksingh commented Mar 17, 2015

Merging.

@peterflynn

This comment has been minimized.

Show comment
Hide comment
@peterflynn

peterflynn Mar 17, 2015

Member

@diomed Just fyi, normally we ask for everything to be reviewed by at least one other person -- please don't take it as doubts about your translating abilities, or anything. You'll see in most other translation pull requests, we try to find a second native speaker to review. If we can't find one, we may use Google Translate to just do a basic check for typos, etc... but we much prefer a real native speaker to review whenever possible.

Member

peterflynn commented Mar 17, 2015

@diomed Just fyi, normally we ask for everything to be reviewed by at least one other person -- please don't take it as doubts about your translating abilities, or anything. You'll see in most other translation pull requests, we try to find a second native speaker to review. If we can't find one, we may use Google Translate to just do a basic check for typos, etc... but we much prefer a real native speaker to review whenever possible.

@diomed diomed deleted the diomed:patch-1 branch Mar 17, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment