Implement progress callback so node domains are able to notify the Brackets before they finish #10761

Merged
merged 2 commits into from Jun 12, 2015

Projects

None yet

4 participants

@zaggino
Member
zaggino commented Mar 19, 2015

Related PR: adobe/brackets-shell#509
Related Issue: #7356

Please review @nethip , I'd like to get this into Brackets as this would help to improve user experience on some of my work I'm doing with extensions.

@zaggino zaggino referenced this pull request in adobe/brackets-shell Mar 19, 2015
Merged

implement sendCommandProgress and progress callback #509

@zaggino
Member
zaggino commented Mar 19, 2015

If we don't want to introduce progressCallback as a new argument to node functions, we can make a call callback(null, null, "progress") to invoke a progress and not resolve the promise checking for arguments.length === 3

@nethip
Contributor
nethip commented Mar 19, 2015

@zaggino Sure! I will take a look at this.

@zaggino
Member
zaggino commented Mar 19, 2015

The more I'm thinking about this, the more callback(null, null, "progress") version makes sense, but I'll wait for some opinions before fixing this PR.

@zaggino zaggino added this to the Release 1.3 milestone Mar 23, 2015
@nethip
Contributor
nethip commented Apr 3, 2015

@zaggino Sorry. I could not find some time to go through this PR as I was caught up with lot of other stuff. I will for sure take a look at this PR next week.

@nethip nethip self-assigned this Apr 3, 2015
@zaggino zaggino referenced this pull request in zaggino/brackets-npm-registry Apr 7, 2015
Closed

Add install progress indicators #11

@zaggino
Member
zaggino commented Apr 23, 2015

So I'm guessing nobody found time to review this for 1.3 ...

@nethip
Contributor
nethip commented Apr 23, 2015

Yes @zaggino That is right. Sorry for not being able to dedicate some time to this PR in this release.

@zaggino zaggino modified the milestone: Release 1.4, Release 1.3 Apr 23, 2015
@nethip nethip was unassigned by zaggino Apr 23, 2015
@zaggino
Member
zaggino commented Apr 27, 2015

Can we get someone to merge this into 1.4?

@prafulVaishnav prafulVaishnav self-assigned this May 6, 2015
@abose abose commented on the diff Jun 11, 2015
test/spec/NodeConnection-test.js
@@ -192,6 +192,42 @@ define(function (require, exports, module) {
});
});
+ it("should receive progress events from asynchronous commands", function () {
@abose
abose Jun 11, 2015 Contributor

@zaggino I ran the Live preview test for Node connection and the test is timing out at should receive progress events from asynchronous commands [win 8.1]. Any idea why?

@prafulVaishnav
prafulVaishnav Jun 12, 2015 Contributor

@abose Have you taken shell changes also? adobe/brackets-shell#509

@abose
abose Jun 12, 2015 Contributor

oh! i didn't that explains. Did you verify this change?

@abose abose assigned abose and unassigned prafulVaishnav Jun 12, 2015
@abose abose merged commit 3348ab0 into master Jun 12, 2015

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@abose abose deleted the zaggino/domain-progress branch Jun 12, 2015
@abose
Contributor
abose commented Jun 12, 2015

Verified, merging.
The corresponding PR adobe/brackets-shell#509 in brackets shell has been merged.
Our linux builds will not pick up this change on brackets shell as we build from the older CEF branch.
So will need to manually add this before release. Adding to release 1.4 checklist #11256 .

@nethip
Contributor
nethip commented Jun 12, 2015

This is going to make @zaggino to see this once he is back from vacation 😄

@zaggino
Member
zaggino commented Jul 9, 2015

Thanks a lot guys for merging this 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment