Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Addresses issue #10846 #10850
@abose @peterflynn (apologies it isn't solely related to #10846 - it felt sensible to combine into one PR)
@thehogfather This looks great overall, thanks for posting this update so quickly! I added a few comments above.
One other note: this fixes bug #10848 for the
@thehogfather Fyi, I've opened PR #10859 with some UI changes as well as a few code tweaks. Some of it duplicates change you've made here (I started working on it before you posted this), so once your PR is merged I'll rebase mine on top of your changes. But please take a look and see if there's anything else there you'd be concerned about.
referenced this pull request
Apr 9, 2015
Btw, it's still a ways off but it will be interesting to think about what having the same document visible in two split panes will mean for code folding. Should collapsing a section in one pane automatically collapse it in the other? Seems like that would feel weird, but otoh if each editor has its own expand/collapse state for the same document, how will that be persisted? Which one "wins" if you close both views? Etc.
I'll add a note to that Trello story so we can think about it more when the time comes.
added a commit
this pull request
Apr 10, 2015
@abose Wait, why did you merge this already? See my comments above -- #10850 (comment) and #10850 (comment) -- code folding persistence is completely broken in master now because of this PR. We should have waited before fixing that blocker before merging...
I'll file a high-priority bug to track it.