Codefolding linefolds syncing fixes #10914

merged 2 commits into from Apr 17, 2015


None yet

2 participants


This PR addresses some inconsistencies with updating the folded states in the folds cache when lines are removed and added.
cc @abose @peterflynn please review and test.

thehogfather added some commits Apr 16, 2015
@thehogfather thehogfather various fixes for line folds syncing when modifying documents 1c0478c
@thehogfather thehogfather Merge commit 'ff49c5c55f5f4c39412647679ba0344c177188e0' into Codefold…

* commit 'ff49c5c55f5f4c39412647679ba0344c177188e0':
  Renaming confuding createIfNew flag to createIfMissing.
  Styling tweaks.
  Added the functionality only for state.json file and also the message when the file is moved to trash.
  delete unreadable pref file so it gets recreated; reset if unparsable
abose commented Apr 16, 2015

Thanks @thehogfather for the quick fix. Will test and update.

abose commented Apr 16, 2015

It looks very stable now, all the cases mentioned in the original bug and comments are now working fine.
All the unit tests are alo passing (exept the 3 pending quick edit ones which we are working on actively to fix.)

@abose abose self-assigned this Apr 16, 2015
abose commented Apr 17, 2015

Thanks, @thehogfather , It works well now in my day of testing, Merging

@abose abose merged commit a74f54f into adobe:master Apr 17, 2015

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment