New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Codefolding linefolds syncing fixes #10914

Merged
merged 2 commits into from Apr 17, 2015

Conversation

Projects
None yet
2 participants
@thehogfather
Contributor

thehogfather commented Apr 16, 2015

This PR addresses some inconsistencies with updating the folded states in the folds cache when lines are removed and added.
cc @abose @peterflynn please review and test.

thehogfather added some commits Apr 16, 2015

Merge commit 'ff49c5c55f5f4c39412647679ba0344c177188e0' into Codefold…
…ing-linefolds-syncing-fixes

* commit 'ff49c5c55f5f4c39412647679ba0344c177188e0':
  Renaming confuding createIfNew flag to createIfMissing.
  Styling tweaks.
  Added the functionality only for state.json file and also the message when the file is moved to trash.
  delete unreadable pref file so it gets recreated; reset if unparsable
@abose

This comment has been minimized.

Show comment
Hide comment
@abose

abose Apr 16, 2015

Contributor

Thanks @thehogfather for the quick fix. Will test and update.

Contributor

abose commented Apr 16, 2015

Thanks @thehogfather for the quick fix. Will test and update.

@abose

This comment has been minimized.

Show comment
Hide comment
@abose

abose Apr 16, 2015

Contributor

It looks very stable now, all the cases mentioned in the original bug and comments are now working fine.
All the unit tests are alo passing (exept the 3 pending quick edit ones which we are working on actively to fix.)

Contributor

abose commented Apr 16, 2015

It looks very stable now, all the cases mentioned in the original bug and comments are now working fine.
All the unit tests are alo passing (exept the 3 pending quick edit ones which we are working on actively to fix.)

@abose

This comment has been minimized.

Show comment
Hide comment
@abose

abose Apr 17, 2015

Contributor

Thanks, @thehogfather , It works well now in my day of testing, Merging

Contributor

abose commented Apr 17, 2015

Thanks, @thehogfather , It works well now in my day of testing, Merging

abose added a commit that referenced this pull request Apr 17, 2015

Merge pull request #10914 from thehogfather/Codefolding-linefolds-syn…
…cing-fixes

Codefolding linefolds syncing fixes

@abose abose merged commit a74f54f into adobe:master Apr 17, 2015

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment