New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sample projects: remove trailing whitespace on non-blank lines, fix arrow #10926

Merged
merged 2 commits into from May 29, 2015

Conversation

Projects
None yet
5 participants
@valtlai
Contributor

valtlai commented Apr 17, 2015

  • remove trailing whitespace on non-blank lines
  • fix an arrow: < to >
  • remove the blank line just before </p>

See #10920, comments 2–3

@valtlai valtlai changed the title from Sample projects: remove trailing whitespace on non-empty lines, fix arrow to Sample projects: remove trailing whitespace on non-blank lines, fix arrow Apr 17, 2015

@@ -57,7 +57,7 @@
<samp>
Une petite démonstration ? Placez le curseur de la souris sur la balise <!-- <samp> --> et tapez <kbd>Cmd/Ctrl + E</kbd>. Un éditeur rapide CSS apparaît en superposition, avec la règle CSS applicable. La fonction Edition rapide est également utilisable pour les attributs de classe et d’ID. Vous pouvez aussi vous en servir sur vos fichiers LESS et SCSS.
Vous pouvez créer de nouvelles règles en procédant de la même manière. Cliquez sur l’une des balises <!-- <p> --> en haut du document et appuyez sur <kbd>Cmd/Ctrl + E&lt;/kbd>. Il n’existe aucune règle associée pour le moment, mais vous pouvez cliquer sur le bouton Nouvelle règle afin d’ajouter une règle pour <!-- <p> -->.
Vous pouvez créer de nouvelles règles en procédant de la même manière. Cliquez sur l’une des balises <!-- <p> --> en haut du document et appuyez sur <kbd>Cmd/Ctrl + E</kbd>. Il n’existe aucune règle associée pour le moment, mais vous pouvez cliquer sur le bouton Nouvelle règle afin d’ajouter une règle pour <!-- <p> -->.

This comment has been minimized.

@peterflynn

peterflynn Apr 20, 2015

Member

Good catch!

@peterflynn

peterflynn Apr 20, 2015

Member

Good catch!

This comment has been minimized.

@peterflynn

peterflynn Apr 20, 2015

Member

@pantkowiak @ybayer Looks like there is an ALF issue here -- both the French & Japanese translations had this character escaped when it should not have been. We should make sure the next ALF update doesn't cause this problem to come back.

@peterflynn

peterflynn Apr 20, 2015

Member

@pantkowiak @ybayer Looks like there is an ALF issue here -- both the French & Japanese translations had this character escaped when it should not have been. We should make sure the next ALF update doesn't cause this problem to come back.

This comment has been minimized.

@pantkowiak

pantkowiak Apr 21, 2015

Contributor

@peterflynn I did some digging, and this is not an ALF issue. Somehow the opening bracket for </kbd> tag was escaped during our pre-process for translation and post-process. This was missed in post-process, because we never had such issue. I've added info about this to our instructions, so this should not be an issue in the future:)

@pantkowiak

pantkowiak Apr 21, 2015

Contributor

@peterflynn I did some digging, and this is not an ALF issue. Somehow the opening bracket for </kbd> tag was escaped during our pre-process for translation and post-process. This was missed in post-process, because we never had such issue. I've added info about this to our instructions, so this should not be an issue in the future:)

@peterflynn

This comment has been minimized.

Show comment
Hide comment
@peterflynn

peterflynn Apr 20, 2015

Member

The HTML spec says > "SHOULD" be escaped as &gt;, but since it also says the motivation for that is buggy older browsers, I think we can ignore that advice -- that change here is ok.

Member

peterflynn commented Apr 20, 2015

The HTML spec says > "SHOULD" be escaped as &gt;, but since it also says the motivation for that is buggy older browsers, I think we can ignore that advice -- that change here is ok.

Brackets. To learn more about how to use the key features, read on.

This comment has been minimized.

@peterflynn

peterflynn Apr 20, 2015

Member

Several other languages have this extra line also. Do you want to remove it in all of them for consistency? (Please squash commits if you do, for history cleanliness).

@peterflynn

peterflynn Apr 20, 2015

Member

Several other languages have this extra line also. Do you want to remove it in all of them for consistency? (Please squash commits if you do, for history cleanliness).

This comment has been minimized.

@valtlai

valtlai Apr 21, 2015

Contributor

@peterflynn Done.

abose added a commit that referenced this pull request May 29, 2015

Merge pull request #10926 from valtlait/valtlait/sample-project
Sample projects: remove trailing whitespace on non-blank lines, fix arrow

@abose abose merged commit 5f2ccda into adobe:master May 29, 2015

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@valtlai valtlai deleted the valtlai:valtlait/sample-project branch Oct 3, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment