New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detect keyword 'linear' on lines containing word 'animation' too #10989

Merged
merged 3 commits into from Jun 20, 2015

Conversation

Projects
None yet
2 participants
@petetnt
Collaborator

petetnt commented Apr 23, 2015

Fixes #10984

@MarcelGerber MarcelGerber self-assigned this Jun 19, 2015

@MarcelGerber

This comment has been minimized.

Show comment
Hide comment
@MarcelGerber

MarcelGerber Jun 19, 2015

Contributor

Could you also add a unit test for this?

Contributor

MarcelGerber commented Jun 19, 2015

Could you also add a unit test for this?

@petetnt

This comment has been minimized.

Show comment
Hide comment
@petetnt

petetnt Jun 19, 2015

Collaborator

@MarcelGerber for the unit tests, should these tests be just repeated with the animation keyword (the unit tests are the same, just with different word IIRC) or should the existing tests be modified to test for both the ´transition" and "animation" keywords?

Collaborator

petetnt commented Jun 19, 2015

@MarcelGerber for the unit tests, should these tests be just repeated with the animation keyword (the unit tests are the same, just with different word IIRC) or should the existing tests be modified to test for both the ´transition" and "animation" keywords?

@MarcelGerber

This comment has been minimized.

Show comment
Hide comment
@MarcelGerber

MarcelGerber Jun 20, 2015

Contributor

It's probably enough to just repeat one or two unit tests with the animation keyword.

Contributor

MarcelGerber commented Jun 20, 2015

It's probably enough to just repeat one or two unit tests with the animation keyword.

@petetnt

This comment has been minimized.

Show comment
Hide comment
@petetnt

petetnt Jun 20, 2015

Collaborator

Added the unit tests

Collaborator

petetnt commented Jun 20, 2015

Added the unit tests

@MarcelGerber

This comment has been minimized.

Show comment
Hide comment
@MarcelGerber

MarcelGerber Jun 20, 2015

Contributor

Thanks!
Merging.

Contributor

MarcelGerber commented Jun 20, 2015

Thanks!
Merging.

MarcelGerber added a commit that referenced this pull request Jun 20, 2015

Merge pull request #10989 from petetnt/linear-keyword-detection-fix
Detect keyword 'linear' on lines containing word 'animation' too

@MarcelGerber MarcelGerber merged commit 7159b14 into adobe:master Jun 20, 2015

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@petetnt petetnt deleted the petetnt:linear-keyword-detection-fix branch Jun 20, 2015

@petetnt

This comment has been minimized.

Show comment
Hide comment
@petetnt

petetnt Jun 20, 2015

Collaborator

👍 awesome

Collaborator

petetnt commented Jun 20, 2015

👍 awesome

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment