New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Korean translation update #11101

Merged
merged 5 commits into from Jun 15, 2015

Conversation

Projects
None yet
5 participants
@revi
Contributor

revi commented May 13, 2015

Mostly proofreading, please refer to the commit messages for details.

Thanks!

revi added some commits May 9, 2015

Proofreading
Mostly space fixing
Another update
* SHA-1 was updated
* Spacing fix 
* Josa(postpositions) fix
Yet another fix
* Space fix
* Postpositions fix - some postpositions were using one form of
postpositions when they can be both of them.
@nethip

This comment has been minimized.

Show comment
Hide comment
@nethip

nethip May 25, 2015

Contributor

@revi Could you add any one who could do a linguistic review of Korean strings?

Contributor

nethip commented May 25, 2015

@revi Could you add any one who could do a linguistic review of Korean strings?

@revi

This comment has been minimized.

Show comment
Hide comment
@revi

revi May 25, 2015

Contributor

@ds5apn per his review on #8262 and @taggon per his review on #10477

Contributor

revi commented May 25, 2015

@ds5apn per his review on #8262 and @taggon per his review on #10477

@abose abose added this to the Release 1.4 milestone Jun 2, 2015

@MarcelGerber

This comment has been minimized.

Show comment
Hide comment
@MarcelGerber

MarcelGerber Jun 12, 2015

Contributor

@ds5apn @taggon @mixed @heisice Could you do a quick linguistic review of these changes?

Contributor

MarcelGerber commented Jun 12, 2015

@ds5apn @taggon @mixed @heisice Could you do a quick linguistic review of these changes?

Show outdated Hide outdated src/nls/ko/strings.js
Show outdated Hide outdated src/nls/ko/strings.js
Show outdated Hide outdated src/nls/ko/strings.js
Show outdated Hide outdated src/nls/ko/strings.js
Show outdated Hide outdated src/nls/ko/strings.js
Show outdated Hide outdated src/nls/ko/strings.js
Show outdated Hide outdated src/nls/ko/strings.js
@taggon

This comment has been minimized.

Show comment
Hide comment
@taggon

taggon Jun 12, 2015

Contributor

@MarcelGerber Done. :)

Contributor

taggon commented Jun 12, 2015

@MarcelGerber Done. :)

@revi

This comment has been minimized.

Show comment
Hide comment
@revi

revi Jun 12, 2015

Contributor

Fixing...

Contributor

revi commented Jun 12, 2015

Fixing...

Fix other errors
Pointed at adobe/brackets#11101

 - Fix double space introduced in previous commit
 - Fix josa errors on {APP_NAME}
 - Fix minor {} closing error
 - Other issues mentioned in the pullrequest
@MarcelGerber

This comment has been minimized.

Show comment
Hide comment
@MarcelGerber

MarcelGerber Jun 13, 2015

Contributor

@taggon: @revi made the changes you suggested. Is this fine with you now?

Contributor

MarcelGerber commented Jun 13, 2015

@taggon: @revi made the changes you suggested. Is this fine with you now?

@taggon

This comment has been minimized.

Show comment
Hide comment
@taggon

taggon Jun 14, 2015

Contributor

Yes, it looks good to me.

Contributor

taggon commented Jun 14, 2015

Yes, it looks good to me.

@MarcelGerber

This comment has been minimized.

Show comment
Hide comment
@MarcelGerber

MarcelGerber Jun 15, 2015

Contributor

Thank you both.
Merging.

Contributor

MarcelGerber commented Jun 15, 2015

Thank you both.
Merging.

MarcelGerber added a commit that referenced this pull request Jun 15, 2015

Merge pull request #11101 from revi/Korean
Korean translation update

@MarcelGerber MarcelGerber merged commit 72d0f5f into adobe:master Jun 15, 2015

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@revi revi deleted the reviforks:Korean branch Jun 16, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment