New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Fix horizontal scrolling of code hints" #11199

Merged
merged 1 commit into from Jun 2, 2015

Conversation

Projects
None yet
3 participants
@sprintr
Contributor

sprintr commented Jun 2, 2015

@sprintr

This comment has been minimized.

Show comment
Hide comment
@sprintr

sprintr Jun 2, 2015

Contributor

@abose @MarcelGerber This should get reverted. We don't need it now.

Contributor

sprintr commented Jun 2, 2015

@abose @MarcelGerber This should get reverted. We don't need it now.

@abose

This comment has been minimized.

Show comment
Hide comment
@abose

abose Jun 2, 2015

Contributor

@MarcelGerber please review this and merge if required.

Contributor

abose commented Jun 2, 2015

@MarcelGerber please review this and merge if required.

@MarcelGerber

This comment has been minimized.

Show comment
Hide comment
@MarcelGerber

MarcelGerber Jun 2, 2015

Contributor

I don't really know... couldn't this be useful for other Code Hint extensions (yet to come)? Or, OTOH, does it change the layout of any Code Hint extension out there (Ternific, for example)?

Contributor

MarcelGerber commented Jun 2, 2015

I don't really know... couldn't this be useful for other Code Hint extensions (yet to come)? Or, OTOH, does it change the layout of any Code Hint extension out there (Ternific, for example)?

@abose

This comment has been minimized.

Show comment
Hide comment
@abose

abose Jun 2, 2015

Contributor

Probably it would be good to revert this back that. that would make it pretty close to the old styles except for the min-width prop. reverting.

Contributor

abose commented Jun 2, 2015

Probably it would be good to revert this back that. that would make it pretty close to the old styles except for the min-width prop. reverting.

abose added a commit that referenced this pull request Jun 2, 2015

Merge pull request #11199 from sprintr/revert-11195-fix-codehints-ove…
…rflow

Revert "Fix horizontal scrolling of code hints"

@abose abose merged commit 015400e into adobe:master Jun 2, 2015

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@sprintr sprintr deleted the sprintr:revert-11195-fix-codehints-overflow branch Jun 2, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment