New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Dutch translation #11208

Merged
merged 3 commits into from Jun 21, 2015

Conversation

Projects
None yet
4 participants
@coreice
Contributor

coreice commented Jun 3, 2015

Added over 200 new strings and removed obsolete strings from older (pre 1.3) Bracket versions. Edited some existing strings to be more accurate. Tried to be as consistent as possible when translating certain jargon.

Update strings.js
Added over 200 new strings en removed obsolete strings from older Bracket versions. Edited some existing strings to be more accurate. Tried to be as consistent as possible when translating certain jargon.
@MarcelGerber

This comment has been minimized.

Show comment
Hide comment
@MarcelGerber

MarcelGerber Jun 3, 2015

Contributor

Thanks for your contribution!
You need to sign the contributor license agreement first, we can't take your changes otherwise.

Contributor

MarcelGerber commented Jun 3, 2015

Thanks for your contribution!
You need to sign the contributor license agreement first, we can't take your changes otherwise.

@MarcelGerber MarcelGerber changed the title from Update strings.js to Update Dutch translation Jun 3, 2015

@abose

This comment has been minimized.

Show comment
Hide comment
@abose

abose Jun 4, 2015

Contributor

@coreice As brackets is an open source project, The contributor license agreement is for your protection as well as the protection of Brackets and its licensees; it does not change your rights to use your own Contributions for any other purpose.

Contributor

abose commented Jun 4, 2015

@coreice As brackets is an open source project, The contributor license agreement is for your protection as well as the protection of Brackets and its licensees; it does not change your rights to use your own Contributions for any other purpose.

@coreice

This comment has been minimized.

Show comment
Hide comment
@coreice

coreice Jun 4, 2015

Contributor

@abose I'm aware of that. I hope my contribution will be approved.

Contributor

coreice commented Jun 4, 2015

@abose I'm aware of that. I hope my contribution will be approved.

@abose

This comment has been minimized.

Show comment
Hide comment
@abose

abose Jun 4, 2015

Contributor

@coreice have you signed the CLA?

Contributor

abose commented Jun 4, 2015

@coreice have you signed the CLA?

@MarcelGerber

This comment has been minimized.

Show comment
Hide comment
@MarcelGerber

MarcelGerber Jun 4, 2015

Contributor

@abose He has (according to grunt cla-check --user=coreice), but the Travis build fails either way for some reason. I've restarted it twice now without success.
E: Oh, I see, it failed for an other reason now. At least the CLA check works 👍

Contributor

MarcelGerber commented Jun 4, 2015

@abose He has (according to grunt cla-check --user=coreice), but the Travis build fails either way for some reason. I've restarted it twice now without success.
E: Oh, I see, it failed for an other reason now. At least the CLA check works 👍

@MarcelGerber

View changes

Show outdated Hide outdated src/nls/nl/strings.js
@MarcelGerber

View changes

Show outdated Hide outdated src/nls/nl/strings.js
@MarcelGerber

This comment has been minimized.

Show comment
Hide comment
@MarcelGerber

MarcelGerber Jun 4, 2015

Contributor

@ispieter @githrdw Would you mind doing a quick review on these changes & additions to the Dutch translation?

Contributor

MarcelGerber commented Jun 4, 2015

@ispieter @githrdw Would you mind doing a quick review on these changes & additions to the Dutch translation?

@abose

This comment has been minimized.

Show comment
Hide comment
@abose

abose Jun 9, 2015

Contributor

@coreice Could you update this PR.
@ispieter Are there any specific modifications that need to be done here?

Contributor

abose commented Jun 9, 2015

@coreice Could you update this PR.
@ispieter Are there any specific modifications that need to be done here?

@ispieter

This comment has been minimized.

Show comment
Hide comment
@ispieter

ispieter Jun 9, 2015

Contributor

Yes, I see several errors in the translations. @abose, what is the best way to mark these? Should I leave a comment on all of them?

Contributor

ispieter commented Jun 9, 2015

Yes, I see several errors in the translations. @abose, what is the best way to mark these? Should I leave a comment on all of them?

@coreice

This comment has been minimized.

Show comment
Hide comment
@coreice

coreice Jun 9, 2015

Contributor

If you can mark these errors I will fix them.

Contributor

coreice commented Jun 9, 2015

If you can mark these errors I will fix them.

@MarcelGerber

This comment has been minimized.

Show comment
Hide comment
@MarcelGerber

MarcelGerber Jun 9, 2015

Contributor

@ispieter It's best to add a line note to every line you'd like to be changed.
It'd be very helpful if you could include both an explanation of what's wrong in your opinion and a suggested correction.

@coreice Please make sure you fix the linting errors and the missppelled key, too.

Contributor

MarcelGerber commented Jun 9, 2015

@ispieter It's best to add a line note to every line you'd like to be changed.
It'd be very helpful if you could include both an explanation of what's wrong in your opinion and a suggested correction.

@coreice Please make sure you fix the linting errors and the missppelled key, too.

@ispieter

View changes

Show outdated Hide outdated src/nls/nl/strings.js
@ispieter

View changes

Show outdated Hide outdated src/nls/nl/strings.js
@ispieter

View changes

Show outdated Hide outdated src/nls/nl/strings.js
@ispieter

View changes

Show outdated Hide outdated src/nls/nl/strings.js
@ispieter

View changes

Show outdated Hide outdated src/nls/nl/strings.js
@ispieter

View changes

Show outdated Hide outdated src/nls/nl/strings.js
@ispieter

View changes

Show outdated Hide outdated src/nls/nl/strings.js
@ispieter

This comment has been minimized.

Show comment
Hide comment
@ispieter

ispieter Jun 9, 2015

Contributor

These are the things that I found. The rest seems fine to me. :)

Contributor

ispieter commented Jun 9, 2015

These are the things that I found. The rest seems fine to me. :)

@coreice

This comment has been minimized.

Show comment
Hide comment
@coreice

coreice Jun 9, 2015

Contributor

Thanks a lot, I will process them :). I hope it will be ready this week but I've a busy schedule so it also could be next week.

Contributor

coreice commented Jun 9, 2015

Thanks a lot, I will process them :). I hope it will be ready this week but I've a busy schedule so it also could be next week.

@abose

This comment has been minimized.

Show comment
Hide comment
@abose

abose Jun 16, 2015

Contributor

Thanks @ispieter for reviewing this. @coreice Did you get a chance to look into this? Brackets will have a release within the next two weeks.

Contributor

abose commented Jun 16, 2015

Thanks @ispieter for reviewing this. @coreice Did you get a chance to look into this? Brackets will have a release within the next two weeks.

@coreice

This comment has been minimized.

Show comment
Hide comment
@coreice

coreice Jun 18, 2015

Contributor

@abose Just returned home from a convention. Will be working on it now :). Do you want me to create a new edit and pull request after I'm done?

Edit 16.02 gmt+2: done with editing the errors.

Contributor

coreice commented Jun 18, 2015

@abose Just returned home from a convention. Will be working on it now :). Do you want me to create a new edit and pull request after I'm done?

Edit 16.02 gmt+2: done with editing the errors.

@abose

This comment has been minimized.

Show comment
Hide comment
@abose

abose Jun 18, 2015

Contributor

👍 Editing this PR would be good for other reviewers to keep track of the changes.

Contributor

abose commented Jun 18, 2015

👍 Editing this PR would be good for other reviewers to keep track of the changes.

Update strings.js
Fixed some errors reported by @MarcelGerber and @ispieter. Also saw some other errors during the process.

Line 133: Changed "Verwijdering" into "Verwijderen".

Line 251, 485, 486, 500, 521, 522 & 589: These lines weren't (correctly) translated in the previous version of my translation.
@coreice

This comment has been minimized.

Show comment
Hide comment
@coreice

coreice Jun 18, 2015

Contributor

Updated the PR. Thanks for checking @MarcelGerber & @ispieter, there were some stupid mistakes in the previous one. I hope this one will be better :).

Contributor

coreice commented Jun 18, 2015

Updated the PR. Thanks for checking @MarcelGerber & @ispieter, there were some stupid mistakes in the previous one. I hope this one will be better :).

@abose abose added this to the Release 1.4 milestone Jun 19, 2015

@MarcelGerber

This comment has been minimized.

Show comment
Hide comment
@MarcelGerber

MarcelGerber Jun 19, 2015

Contributor

@ispieter Does this look good to you?

Contributor

MarcelGerber commented Jun 19, 2015

@ispieter Does this look good to you?

@MarcelGerber

This comment has been minimized.

Show comment
Hide comment
@MarcelGerber

MarcelGerber Jun 19, 2015

Contributor

You should also update the SHA comment at the very bottom. This is based on 50cbe1b (50cbe1b8848786c6be27d4788e4b6a367244abc2), I guess.

Contributor

MarcelGerber commented Jun 19, 2015

You should also update the SHA comment at the very bottom. This is based on 50cbe1b (50cbe1b8848786c6be27d4788e4b6a367244abc2), I guess.

@coreice

This comment has been minimized.

Show comment
Hide comment
@coreice

coreice Jun 20, 2015

Contributor

@MarcelGerber You're right. Fixed the SHA comment.

Contributor

coreice commented Jun 20, 2015

@MarcelGerber You're right. Fixed the SHA comment.

@ispieter

This comment has been minimized.

Show comment
Hide comment
@ispieter

ispieter Jun 21, 2015

Contributor

Yes, looks good to me.

Contributor

ispieter commented Jun 21, 2015

Yes, looks good to me.

@MarcelGerber

This comment has been minimized.

Show comment
Hide comment
@MarcelGerber

MarcelGerber Jun 21, 2015

Contributor

Thank you @coreice @ispieter.
Merging.

Contributor

MarcelGerber commented Jun 21, 2015

Thank you @coreice @ispieter.
Merging.

MarcelGerber added a commit that referenced this pull request Jun 21, 2015

@MarcelGerber MarcelGerber merged commit 53165a1 into adobe:master Jun 21, 2015

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment