New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow JavaScript Code Hints only in its context #11263

Merged
merged 1 commit into from Jun 22, 2015

Conversation

Projects
None yet
4 participants
@sprintr
Contributor

sprintr commented Jun 13, 2015

Fixes a regression I made in #11245 where JavaScript code hints were globally available in a PHP document. This will make sure they are only available inside script tags.

@MarcelGerber MarcelGerber added this to the Release 1.4 milestone Jun 13, 2015

@abose abose self-assigned this Jun 15, 2015

@@ -56,6 +56,9 @@ define(function (require, exports, module) {
noHintsOnDot = false, // preference setting to prevent hints on dot
ignoreChange; // can ignore next "change" event if true;
// Languages that support inline JavaScript
var _inlineScriptLanguages = ["html", "php"];

This comment has been minimized.

@abose

abose Jun 15, 2015

Contributor

Would it make sense to define this as a preference?

@abose

abose Jun 15, 2015

Contributor

Would it make sense to define this as a preference?

This comment has been minimized.

@sprintr

sprintr Jun 15, 2015

Contributor

Don't think so. These are the only two languages that support inline JS.

@sprintr

sprintr Jun 15, 2015

Contributor

Don't think so. These are the only two languages that support inline JS.

This comment has been minimized.

@sprintr

sprintr Jun 15, 2015

Contributor

In case someone wants to disable JavaScript code hints in PHP, they can use language/php layer to disable them.

@sprintr

sprintr Jun 15, 2015

Contributor

In case someone wants to disable JavaScript code hints in PHP, they can use language/php layer to disable them.

This comment has been minimized.

@abose

abose Jun 15, 2015

Contributor

jsp/asp I remember can do similar js mixin as PHP.

@abose

abose Jun 15, 2015

Contributor

jsp/asp I remember can do similar js mixin as PHP.

This comment has been minimized.

@sprintr

sprintr Jun 15, 2015

Contributor

@abose jsp/asp files will be highlighted as html files.

@sprintr

sprintr Jun 15, 2015

Contributor

@abose jsp/asp files will be highlighted as html files.

This comment has been minimized.

@TomMalbran

TomMalbran Jun 15, 2015

Contributor

Maybe is something that could be defined as part of the language in the LanguageManager?

@TomMalbran

TomMalbran Jun 15, 2015

Contributor

Maybe is something that could be defined as part of the language in the LanguageManager?

abose added a commit that referenced this pull request Jun 22, 2015

Merge pull request #11263 from sprintr/fix-php-js-hints
Allow JavaScript Code Hints only in its context

@abose abose merged commit 4f7be02 into adobe:master Jun 22, 2015

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@abose

This comment has been minimized.

Show comment
Hide comment
@abose

abose Jun 22, 2015

Contributor

Looks good. Merging.

Contributor

abose commented Jun 22, 2015

Looks good. Merging.

@sprintr sprintr deleted the sprintr:fix-php-js-hints branch Jun 23, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment