New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix unittests #11275

Merged
merged 1 commit into from Jun 16, 2015

Conversation

Projects
None yet
2 participants
@sprintr
Contributor

sprintr commented Jun 15, 2015

Fixes errors in unit tests caused by #11201.

CC: @abose

abose added a commit that referenced this pull request Jun 16, 2015

@abose abose merged commit 0303dc5 into adobe:master Jun 16, 2015

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@abose

This comment has been minimized.

Show comment
Hide comment
@abose

abose Jun 16, 2015

Contributor

Fixed, merging.

Contributor

abose commented Jun 16, 2015

Fixed, merging.

@sprintr

This comment has been minimized.

Show comment
Hide comment
@sprintr

sprintr Jun 16, 2015

Contributor

@abose Did all of them pass this time?

Contributor

sprintr commented Jun 16, 2015

@abose Did all of them pass this time?

@abose

This comment has been minimized.

Show comment
Hide comment
@abose

abose Jun 16, 2015

Contributor

Yes all tests passed.
If you noticed that live Preview tests failed, that intermittently happens, usually some timeout issues, but will pass eventually on reruns.

Contributor

abose commented Jun 16, 2015

Yes all tests passed.
If you noticed that live Preview tests failed, that intermittently happens, usually some timeout issues, but will pass eventually on reruns.

@sprintr

This comment has been minimized.

Show comment
Hide comment
@sprintr

sprintr Jun 16, 2015

Contributor

@abose Only 1 live preview test passed for me at first run.

Contributor

sprintr commented Jun 16, 2015

@abose Only 1 live preview test passed for me at first run.

@sprintr sprintr deleted the sprintr:fix-unittests branch Jun 16, 2015

@abose

This comment has been minimized.

Show comment
Hide comment
@abose

abose Jun 16, 2015

Contributor

yes i too get that at times, but reruns usually does the trick. Might be some timing issue.

Contributor

abose commented Jun 16, 2015

yes i too get that at times, but reruns usually does the trick. Might be some timing issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment