Explicitly check for mac platform before using Cmd key for Ctrl in shortcuts #1134

merged 2 commits into from Jun 24, 2012


None yet

2 participants


Fix KeyBindingManager unit test failed issue #1132

@gruehle gruehle was assigned Jun 23, 2012
gruehle commented Jun 23, 2012

This fixes all of the unit test on windows and most of the tests on the mac. I'm still seeing one error in the Menus tests on the mac.

@RaymondLim RaymondLim Temporarily commenting out the expect call since we should be expecti…
…ng it to be Cmd-9 on Mac, but I need to get the platform information to check it conditionally.
gruehle commented Jun 24, 2012

Tests all pass now. Could you file a bug to fix the menu tests? Ideally we would check for mac and windows bindings for newly-created menu items.

@gruehle gruehle merged commit 88718fc into master Jun 24, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment