Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.Sign up
GitHub is where the world builds software
Millions of developers and companies build, ship, and maintain their software on GitHub — the largest and most advanced development platform in the world.
Fix to prevent moving files by renaming files using FileTreeView #11862
However, it's only a partial fix for all the issues listed in #11609. It solves the main one, but the others still remain.
Some tests cases that should fail:
Which platform are you on? At least on Windows the validation fails with
Let's create a folder
and try that again
it actually created the other file too (like one could except if relative paths would be valid
(The foo/bar.js file opens the correct file too, so there's that).
Similar things can be done with things like creating folders by naming a file with ending slash et cetera and it can be abused to infinity. That's why I think it's important that the fix would apply to all the cases regarding
Works great for renaming old files on Windows
However, creating a new file and renaming that instantly skips
Check out this if-clause
I intentionally left out createAtPath workflow as I believe its out of the scope of this PR. I completely understand the workflow mentioned above but I am skeptical of this being called a bug or not. Couple of reasons :
I would prefer discussing that over the group once and once confirmed , I myself am willing to make that change too :)