This repository has been archived by the owner on Sep 6, 2021. It is now read-only.
Fix npe in ProjectManager.js #123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasonsanjose
added a commit
that referenced
this pull request
Jan 21, 2012
Fix npe in ProjectManager.js
|
I believe this causes issue #84 to repro again. Chris and I looked at this earlier on Friday. Basically, jQuery is not robust to event handlers crashing: if one handler crashes, no more handlers are run because the whole call stack unwinds. So, the NPE was fixing #84 by preventing the jsTree dblclick handler from ever running. With the crash fixed, the bug repros again -- so focusEditor() itself is not actually a fix for the issue. Since this is clearly and improvement, though, I'll let this lie and then reopen #84 :-) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's some code in ProjectManager.js that's calling EditorManager, but EditorManager wasn't imported, so an exception was being thrown. This fixes the problem.