Issue 1715 #13105

Closed
wants to merge 2 commits into
from

Projects

None yet

3 participants

@Blackweda
Blackweda commented Feb 16, 2017 edited

Hi,

I am trying to solve the issue: mozilla/thimble.mozilla.org#1715
It asked for nunjucks 2.4.3 to be added to both Brackets and Thimble.
It was already present in Thimble, but I didn't see it in Brackets.

I added it into the dependencies list, yet I'm unsure if that was a wise thing to do. Please consider using the
code and let me know if it works or not, and where to make changes elsewhere.

@zaggino
Member
zaggino commented Feb 16, 2017

Hi, you're probably referencing a wrong issue in the description. Also, adding something to the dependency list doesn't do anything until you use it somewhere in the code.

@ficristo
Member

Hi @Blackweda,
I think you have to open your PRs at https://github.com/mozilla/thimble.mozilla.org and at the mozilla fork of Brackets https://github.com/mozilla/brackets
We don't use nunjucks.

@ficristo ficristo closed this Feb 17, 2017
@Blackweda

@ficristo thanks, makes sense! will do.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment