download eslint package from npm and place it into default extensions #13108

Open
wants to merge 1 commit into
from

Projects

None yet

2 participants

@zaggino
Member
zaggino commented Feb 17, 2017

Related to #11984

As a part of this PR I'd like to make a change, that when brackets-eslint is found in extensions/user directory, it won't be loaded from extensions/default directory - I'd like your thoughts on that.

@zaggino zaggino added the Enhancement label Feb 17, 2017
@zaggino zaggino self-assigned this Feb 17, 2017
@zaggino zaggino requested review from petetnt, ficristo, and swmitra Feb 17, 2017
@ficristo
Member

I think Atom added a new field in their package.json, packageDependencies, and use it to install their extensions. I think I prefer their approach.
For the linters, I still don't understand what Adobe wants to do...

@zaggino
Member
zaggino commented Feb 17, 2017

@ficristo Can you shine a bit more light how these packageDependencies should work here? Happy to make changes to the PR

@ficristo
Member

I didn't look at Atom implementation, but I think the usage is similar to the node dependencies.
In the package.json of Atom they have something like:

"packageDependencies": {
  "atom-dark-syntax": "0.28.0",
  "atom-dark-ui": "0.53.0",
  "...": "..."
}

We could have something like:

"dependencies": {
  "chokidar": "1.6.0",
  "...": "..."
},
"devDependencies": {
  "grunt": "0.4.5",
  "...": "..."
},
"packageDependencies": {
  "brackets-eslint": "1.0.0",
  "...": "..."
}

and use npm to install them.
If I understood correctly, you have done this but hardcoded the dependencies in the scripts.
I only think we have to move them on the package.json so to make easier to keep track of what we use.
Of course is totally possible there are some drawback that ATM I don't see.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment