fix getItemsPerPage() #1357

merged 1 commit into from Aug 9, 2012


None yet
2 participants

redmunds commented Aug 9, 2012

Don't cache itemsPerPage, because user can press PageUp/Down key when list is not full height.

This pull request fixes the following problem:

  1. Start Brackets
  2. Type in a page to invoke the code hints window
  3. Filter in such as way that there are less than 8 items in list
  4. Press up PageUp or PageDown
    Important: this has to be the first time PageUp or Page down is pressed in code hints list
  5. Now invoke code hints with full list
  6. Press up PageUp or PageDown again

Notice that it only advances the height as when first pressed, not 8.

tvoliter added a commit that referenced this pull request Aug 9, 2012

@tvoliter tvoliter merged commit 5c24dd1 into master Aug 9, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment