From f4f549b84c08e561171184cc98a4579008feae17 Mon Sep 17 00:00:00 2001 From: niteskum Date: Fri, 5 Apr 2019 12:52:05 +0530 Subject: [PATCH 1/2] Php Tooling Strings changes --- src/nls/root/strings.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/nls/root/strings.js b/src/nls/root/strings.js index 088b6e02489..c9df71fba0f 100644 --- a/src/nls/root/strings.js +++ b/src/nls/root/strings.js @@ -880,7 +880,7 @@ define({ ///String for Php Tooling Extensions "PHP_VERSION_INVALID" : "Error parsing PHP version. Please check the output of the “php –version” command.", "PHP_UNSUPPORTED_VERSION" : "Install PHP7 runtime for enabling PHP-related tooling such as Code Hints, Parameter Hints, Jump To Definition and more. Version found: {0}", - "PHP_EXECUTABLE_NOT_FOUND" : "PHP runtime not found. Install PHP7 runtime and set the path to system PATH or executablePath in php Preferences appropriately.", + "PHP_EXECUTABLE_NOT_FOUND" : "PHP runtime not found. Install PHP7 runtime and add the path to system PATH or executablePath in php Preferences appropriately for enabling PHP-related tooling such as Code Hints, Parameter Hints, Jump To Definition and more.", "PHP_PROCESS_SPAWN_ERROR" : "Error code {0} encountered while starting the PHP process.", "PHP_SERVER_ERROR_TITLE" : "Error", "PHP_SERVER_MEMORY_LIMIT_INVALID" : "The memory limit you provided is invalid. Review the PHP preferences to set the correct value.", From 7b3bb43bf0d0037d709ecdf9cc96dd5222a2c30f Mon Sep 17 00:00:00 2001 From: niteskum Date: Mon, 8 Apr 2019 14:01:01 +0530 Subject: [PATCH 2/2] Addressed review comments --- src/nls/root/strings.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/nls/root/strings.js b/src/nls/root/strings.js index c9df71fba0f..e20af5d20d8 100644 --- a/src/nls/root/strings.js +++ b/src/nls/root/strings.js @@ -880,7 +880,7 @@ define({ ///String for Php Tooling Extensions "PHP_VERSION_INVALID" : "Error parsing PHP version. Please check the output of the “php –version” command.", "PHP_UNSUPPORTED_VERSION" : "Install PHP7 runtime for enabling PHP-related tooling such as Code Hints, Parameter Hints, Jump To Definition and more. Version found: {0}", - "PHP_EXECUTABLE_NOT_FOUND" : "PHP runtime not found. Install PHP7 runtime and add the path to system PATH or executablePath in php Preferences appropriately for enabling PHP-related tooling such as Code Hints, Parameter Hints, Jump To Definition and more.", + "PHP_EXECUTABLE_NOT_FOUND" : "PHP runtime not found. Install the PHP7 runtime and update “executablePath” in PHP Preferences appropriately. This enables PHP-related tooling such as Code Hints, Parameter Hints, Jump To Definition and more.", "PHP_PROCESS_SPAWN_ERROR" : "Error code {0} encountered while starting the PHP process.", "PHP_SERVER_ERROR_TITLE" : "Error", "PHP_SERVER_MEMORY_LIMIT_INVALID" : "The memory limit you provided is invalid. Review the PHP preferences to set the correct value.",