Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Statusbar for Brackets #1717
Adds a bottom status bar in the content area to show general editor settings and other status indicators. This is inspired by this user story https://trello.com/card/2-status-bar-bottom/4f90a6d98f77505d7940ce88/337
I'm creating this pull request because I'm not sure about the right process and maybe I'm going a little over my head here... I think it still needs some work and discussion if you'd want to add it, so maybe it would be best if it could be forked and polished to reach a better state before trying to merge it.
As suggested in the card, the status bar sits at the bottom of the editor and shows the line and column number, number of lines, mode and current tab setting for the current focused editor.
These APIs are a possible solution (at least partial) for the story in this card https://trello.com/card/ui-for-long-running-operatons/4f90a6d98f77505d7940ce88/551. The status bar includes a busy indicator that any module can show or hide through these methods. Additionally,
In this pull request, the
These APIs allow any module to add an indicator on the status bar and update it at any time.
In this pull request, and just as a test for the API, the
Sorry for the long and booring post :)
PS: Although not yet finished, the status bar also comes in a Brackets Extension flavour https://github.com/jbalsas/brackets-statusbar-extension ;)
@jbalsas -- this is totally sweet. We literally just got out of our planning meetings for the next sprint, and one of the tasks we added was for a status bar :) We mainly wanted to add it to support adding a simple switcher for spaces vs. tabs, so what you've got could be a great start.
We'll try to do a closer review over the next few days and suggest improvements if any. Thanks!
BTW, you can see a mockup that @GarthDB made for the status bar in the Extension UI Guidelines doc on the wiki: https://github.com/adobe/brackets/wiki/Extension-UI-Guidelines (search for the "Status Bar" section). Aside from the internal layout/positioning of the items in the status bar, the main differences are in the background color, font size and vertical padding. Probably worth tweaking those simple visual issues first--the internal layout stuff is probably a bigger question that's worth some discussion.
I'll try and take a look at the request and your current UI sometime tonight.
Sent from my iPhone
On Sep 25, 2012, at 4:56 PM, Narciso Jaramillo firstname.lastname@example.org wrote:
There is a design done for reflow. I'll look into it.
Sent from my iPhone
On Sep 25, 2012, at 6:19 PM, Narciso Jaramillo email@example.com wrote:
Initial review complete. Hopefully this is mostly just cleanup and not a ton of refactoring. Our goal is to merge this in as soon as possible to unblock the tabs/spaces story https://trello.com/c/exOQhrGw. If you're too busy to take on these code review changes, we can also help.
Thanks for the great contribution. The timing couldn't be better.