Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Factor out generic token-navigation routines from HTMLUtils #1753

Merged
merged 1 commit into from Oct 3, 2012

Conversation

Projects
None yet
2 participants
Member

njx commented Oct 3, 2012

HTMLUtils had a number of private functions that navigate through the CodeMirror code coloring tokens in the current editor. These are completely generic (not specific to HTML), and would be useful for extensions that need to do light parsing based on the tokenization. This pull request factors those functions out into a separate TokenUtils class.

@ghost ghost assigned peterflynn Oct 3, 2012

Member

njx commented Oct 3, 2012

Member

peterflynn commented Oct 3, 2012

Cool. Eventually I think we should have a TokenIterator sort of class that packages this up even more cleanly (and probably hides _codeMirror a bit better too), and this seems like a solid step in that direction.

Diff looks good to me -- merging.

@peterflynn peterflynn added a commit that referenced this pull request Oct 3, 2012

@peterflynn peterflynn Merge pull request #1753 from adobe/nj/factor-token-utils
Factor out generic token-navigation routines from HTMLUtils
04bcf56

@peterflynn peterflynn merged commit 04bcf56 into master Oct 3, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment