Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP

Loading…

Improved error message when trying to overwrite an existing key binding #1851

Merged
merged 1 commit into from

2 participants

@DennisKehrig
Collaborator

Before:
"Cannot assign Shift-Cmd-E to i10.extension_manager.show. It is already assigned to [object Object]"

Now:
"Cannot assign Shift-Cmd-E to i10.extension_manager.show. It is already assigned to pflynn.searchWorkingSetFiles"

@gruehle
Owner

Thanks - nice catch! Merging

@gruehle gruehle merged commit 22f5ff9 into adobe:master
@gruehle gruehle referenced this pull request from a commit
Commit has since been removed from the repository and is no longer available.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
This page is out of date. Refresh to see the latest.
Showing with 1 addition and 1 deletion.
  1. +1 −1  src/command/KeyBindingManager.js
View
2  src/command/KeyBindingManager.js
@@ -326,7 +326,7 @@ define(function (require, exports, module) {
// skip if the key is already assigned
if (_isKeyAssigned(normalized)) {
console.log("Cannot assign " + normalized + " to " + commandID +
- ". It is already assigned to " + _keyMap[normalized]);
+ ". It is already assigned to " + _keyMap[normalized].commandID);
return null;
}
Something went wrong with that request. Please try again.