Forgot to fix up other callers to functions with changed signature #2332

merged 1 commit into from Dec 12, 2012


None yet

2 participants

Adobe Systems Incorporated member

Noticed by @peterflynn. This made it so arrowing through the entries, then hitting RETURN, would jump back to the first entry. (Didn't seem to repro on all systems, for some reason.)

@peterflynn peterflynn was assigned Dec 11, 2012
Adobe Systems Incorporated member

Looks good, and fixes the bug for me.

It's pretty sketchy that it was UTR for you, though. It looks like we respond to Enter on keydown, and SmartAutocomplete responds in basically the same way on keyup. I'm not sure why we need a handler, and why their key handler sometimes runs after the toolbar is removed from the DOM (which our handler does immediately, on keydown). I'll make a note in #1855 about trying to understand this better.

@peterflynn peterflynn merged commit 9738bd7 into master Dec 12, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment