Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

Remove extra divider from help menu #2834

Merged
merged 1 commit into from

2 participants

@gruehle
Owner

If the Help menu doesn't have a twitter url or about item, don't show a divider at the end.

@peterflynn
Owner

Looks good to me. Merging.

@peterflynn peterflynn merged commit 722f7ec into from
@peterflynn peterflynn deleted the branch
@peterflynn peterflynn referenced this pull request from a commit
Commit has since been removed from the repository and is no longer available.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on Feb 8, 2013
  1. @gruehle
This page is out of date. Refresh to see the latest.
Showing with 8 additions and 2 deletions.
  1. +8 −2 src/command/Menus.js
View
10 src/command/Menus.js
@@ -1113,12 +1113,18 @@ define(function (require, exports, module) {
menu.addMenuItem(Commands.HELP_SHOW_EXT_FOLDER);
- menu.addMenuDivider();
+ var hasAboutItem = (brackets.platform !== "mac" || brackets.inBrowser);
+
+ // Add final divider only if we have a twitter URL or about item
+ if (hasAboutItem || brackets.config.twitter_url) {
+ menu.addMenuDivider();
+ }
+
if (brackets.config.twitter_url) {
menu.addMenuItem(Commands.HELP_TWITTER);
}
// supress redundant about menu item in mac shell
- if (brackets.platform !== "mac" || brackets.inBrowser) {
+ if (hasAboutItem) {
menu.addMenuItem(Commands.HELP_ABOUT);
}
Something went wrong with that request. Please try again.