Add check for broken symlinks to hacking scripts (#2895) #2896

Merged
merged 1 commit into from Feb 20, 2013

Projects

None yet

3 participants

@jbalsas
Member
jbalsas commented Feb 16, 2013

This is a possible fix for #2895.

It adds an additional check for broken symlinks to the current condition.

@gruehle gruehle was assigned Feb 19, 2013
@peterflynn
Member

Is there a Windows equivalent to this bug too, or do the .bat files work differently?

@jbalsas
Member
jbalsas commented Feb 20, 2013

Yeah, sorry, I forgot to mention that :/ ... I currently don't have access to any windows machine, so I couldn't test it and I can't tell for sure.

From what I saw, the .bat files are checking if exist %1\dev where the .sh were doing if [ -d "${1}/Contents/dev" ]. I'm not quite sure if the condition will fail in windows for broken symlinks, or if it will just check they exist, and I haven't been able to find information about it.

It'd be great if someone could do a quick check, just to be sure.

@gruehle
Member
gruehle commented Feb 20, 2013

Works great! The Windows version was fine as-is.

@gruehle gruehle merged commit 52da880 into adobe:master Feb 20, 2013

1 check passed

Details default The Travis build passed
@jbalsas jbalsas deleted the jbalsas:fix-2895 branch Feb 20, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment