Improve Live Dev test reliability #3134

Merged
merged 6 commits into from Mar 16, 2013

Conversation

Projects
None yet
2 participants
Contributor

redmunds commented Mar 14, 2013

LiveDevelopment status getting set to STATUS_ACTIVE happens after the Inspector becomes connected, so this is a better event to wait for. This removes the need to blindly wait an extra second just to be safe.

Also, this will detect the case that LiveDevelopment stays in the "Initializing..." state.

@gruehle Signed up to code review

gruehle was assigned Mar 14, 2013

Member

gruehle commented Mar 16, 2013

Looks good, and definitely improves the tests. Thanks!

@gruehle gruehle added a commit that referenced this pull request Mar 16, 2013

@gruehle gruehle Merge pull request #3134 from adobe/randy/live-dev-ut
Improve Live Dev test reliability
604b27f

@gruehle gruehle merged commit 604b27f into master Mar 16, 2013

1 check passed

default The Travis build passed
Details

gruehle deleted the randy/live-dev-ut branch Mar 16, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment