Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
If live dev page leaves site, then terminate live dev #3141
This is a fix for #2277.
Note that this bug says that element highlighting should stop when another url is entered, but it seems like we should allow other urls as long as user stays within site. Once site is left, then highlighting is stopped.
Also, it only says that highlighting should stop, but it seems like everything should stop, so the live dev connection is killed.
This feels kind of quick & dirty, so I am curious what I'm missing here. If this is a good enough starting point, then I'll add an integration test.
Took a quick look. I think the behavior makes sense (at least until/unless we redefine the overall live dev workflow anyway)--we don't currently really define what should happen if you navigate within the browser anyway.
The basic idea of your implementation seems fine too, but looking at the code, it looks like you might want to call
Actually, @iwehrman points out that
Ian is in the middle of putting up some changes to how all this stuff works, so I think we should wait for that to land (or know what it looks like) before getting further into fixing this issue.
This comment has been minimized.
This comment has been minimized.Show comment Hide comment
Good catch! It was caused by an iframe. Fixed.