Restore binding for frameNavigated event #3171

Merged
merged 1 commit into from Mar 19, 2013

Conversation

Projects
None yet
2 participants
@redmunds
Contributor

redmunds commented Mar 19, 2013

This is for #2277 (again)

@iwehrman @gruehle I can't quite tell from the github history (which is kinda scary), but this event binding got stomped somewhere between sha f3419c1 and 5488286.

@iwehrman

This comment has been minimized.

Show comment Hide comment
@iwehrman

iwehrman Mar 19, 2013

Contributor

I must have screwed this up somehow when I merged master in to my branch in 5488286 🙈

Contributor

iwehrman commented Mar 19, 2013

I must have screwed this up somehow when I merged master in to my branch in 5488286 🙈

@redmunds

This comment has been minimized.

Show comment Hide comment
@redmunds

redmunds Mar 19, 2013

Contributor

@iwehrman FYI, I have never found a fool proof code merging tool, so I always visually diff the code after any automatic merging has been done.

Contributor

redmunds commented Mar 19, 2013

@iwehrman FYI, I have never found a fool proof code merging tool, so I always visually diff the code after any automatic merging has been done.

@redmunds

This comment has been minimized.

Show comment Hide comment
@redmunds

redmunds Mar 19, 2013

Contributor

@iwehrman You have commit authority, right? If so, please merge, otherwise let me know.

Contributor

redmunds commented Mar 19, 2013

@iwehrman You have commit authority, right? If so, please merge, otherwise let me know.

@iwehrman

This comment has been minimized.

Show comment Hide comment
@iwehrman

iwehrman Mar 19, 2013

Contributor

OK, merging.

Contributor

iwehrman commented Mar 19, 2013

OK, merging.

iwehrman added a commit that referenced this pull request Mar 19, 2013

@iwehrman iwehrman merged commit bf8406e into master Mar 19, 2013

1 check passed

default The Travis build passed
Details

@iwehrman iwehrman deleted the randy/fix-frame-nav-event-binding branch Mar 19, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment