Fixed: Issue 3041 If you remove displayKey for Decrease Font Size shortcut, it will show up as Ctrl++ on Window #3331

Merged
merged 2 commits into from Apr 16, 2013

Conversation

Projects
None yet
3 participants
Contributor

WebsiteDeveloper commented Apr 3, 2013

Fix for #3041 by mimiking a negative lookbehind.

Member

peterflynn commented Apr 4, 2013

I think you could use regular lookahead: .replace(/-(?!$)/g, "+")

This expression seems like a closer match to what we're trying to accomplish anyway: we don't care about doubled "--"s so much as we care about "-"s that are the last char in the string (i.e. "-"s that are the keystroke rather than the delimiter).

Contributor

WebsiteDeveloper commented Apr 4, 2013

you are right, as the "-" we care about will always be at the end of the string this should work too.

Contributor

WebsiteDeveloper commented Apr 4, 2013

@peterflynn changes pushed.

Contributor

RaymondLim commented Apr 16, 2013

Looks good. Merging.

@RaymondLim RaymondLim added a commit that referenced this pull request Apr 16, 2013

@RaymondLim RaymondLim Merge pull request #3331 from WebsiteDeveloper/Issue-3041
Fixed: Issue 3041 If you remove displayKey for Decrease Font Size shortcut, it will show up as Ctrl++ on Window
2a42e9e

@RaymondLim RaymondLim merged commit 2a42e9e into adobe:master Apr 16, 2013

1 check passed

default The Travis build passed
Details

WebsiteDeveloper deleted the WebsiteDeveloper:Issue-3041 branch Apr 17, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment