Skip to content

Remove JS hinter cruft #3375

Merged
merged 1 commit into from Apr 22, 2013

4 participants

@iwehrman
Adobe Systems Incorporated member
iwehrman commented Apr 8, 2013

I don't know how these triggerHandler calls got leaked into this branch, but git blame implicates me. They serve no purpose here and should be removed.

@redmunds

@dangoor Since you're reviewing the new JavaScript Code Hint code, can you comment on whether this pull request is obsolete?

@dangoor dangoor was assigned Apr 19, 2013
@dangoor
dangoor commented Apr 19, 2013

@redmunds thanks for letting me know. I actually had it on my todo list to take a look at this once the tern integration had landed.

I may not get to this today, though. @eztierney could take a look as well, if he has cycles.

@dangoor
dangoor commented Apr 22, 2013

This pull request appears to still be valid. It doesn't merge automatically, but the changes are simple and still seem relevant.

@eztierney do you see any problem with these changes?

@eztierney

@dangoor looks good to me - I don't see any problems with this change

@dangoor dangoor merged commit 9bb2a46 into master Apr 22, 2013

1 check passed

Details default The Travis build passed
@dangoor dangoor deleted the iwehrman/js-hinter-cruft-removal branch Apr 22, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.