From c99847f205d89ce0655280102ec832ada0b801e9 Mon Sep 17 00:00:00 2001 From: Jeffrey Fisher Date: Tue, 30 Apr 2013 23:44:52 -0700 Subject: [PATCH 1/2] Issue #3131 - Making JSLint errors copyable --- .../default/JSLint/htmlContent/bottom-panel.html | 2 +- .../default/WebPlatformDocs/WebPlatformDocs.less | 7 +------ src/styles/brackets.less | 12 ++++++------ src/styles/brackets_mixins.less | 10 ++++++++++ src/styles/brackets_patterns_override.less | 14 ++------------ 5 files changed, 20 insertions(+), 25 deletions(-) diff --git a/src/extensions/default/JSLint/htmlContent/bottom-panel.html b/src/extensions/default/JSLint/htmlContent/bottom-panel.html index 668d1465387..c1e5ac7186a 100644 --- a/src/extensions/default/JSLint/htmlContent/bottom-panel.html +++ b/src/extensions/default/JSLint/htmlContent/bottom-panel.html @@ -1,4 +1,4 @@ -
+
{{JSLINT_ERRORS}}
diff --git a/src/extensions/default/WebPlatformDocs/WebPlatformDocs.less b/src/extensions/default/WebPlatformDocs/WebPlatformDocs.less index 154a1d8c505..a45bbdb9075 100644 --- a/src/extensions/default/WebPlatformDocs/WebPlatformDocs.less +++ b/src/extensions/default/WebPlatformDocs/WebPlatformDocs.less @@ -16,12 +16,7 @@ /* Enable text selection */ cursor: auto; - -webkit-user-select: text; - -khtml-user-select: text; - -moz-user-select: text; - -ms-user-select: text; - -o-user-select: text; - user-select: text; + .user-select(text); &:focus { outline: none; diff --git a/src/styles/brackets.less b/src/styles/brackets.less index 3c55d666f2b..68e155adcdd 100644 --- a/src/styles/brackets.less +++ b/src/styles/brackets.less @@ -48,12 +48,7 @@ html, body { overflow: hidden; /* Turn off selection for UI elements */ - -webkit-user-select: none; - -khtml-user-select: none; - -moz-user-select: none; - -ms-user-select: none; - -o-user-select: none; - user-select: none; + .user-select(none); /* And make sure we get a pointer cursor even over text */ cursor: default; @@ -839,3 +834,8 @@ li.smart_autocomplete_highlight { background-size: 100%; } } + +/* Turn on text selection for JSLint error messages */ +#jslint-results { + .user-select(text); +} diff --git a/src/styles/brackets_mixins.less b/src/styles/brackets_mixins.less index 82f18a19a5e..89574a8ddbd 100644 --- a/src/styles/brackets_mixins.less +++ b/src/styles/brackets_mixins.less @@ -118,3 +118,13 @@ -o-transform-origin: @horizontal @vertical; transform-origin: @horizontal @vertical; } + +/* Change the settings for user-select and its counterparts, defaulting to none. */ +.user-select(@type: none) { + -webkit-user-select: @type; + -khtml-user-select: @type; + -moz-user-select: @type; + -ms-user-select: @type; + -o-user-select: @type; + user-select: @type; +} \ No newline at end of file diff --git a/src/styles/brackets_patterns_override.less b/src/styles/brackets_patterns_override.less index fc5a7aa0442..a5752876a32 100644 --- a/src/styles/brackets_patterns_override.less +++ b/src/styles/brackets_patterns_override.less @@ -441,12 +441,7 @@ // Enable text selection cursor: auto; - -webkit-user-select: text; - -khtml-user-select: text; - -moz-user-select: text; - -ms-user-select: text; - -o-user-select: text; - user-select: text; + .user-select(text); } } } @@ -563,12 +558,7 @@ // Enable text selection cursor: auto; - -webkit-user-select: text; - -khtml-user-select: text; - -moz-user-select: text; - -ms-user-select: text; - -o-user-select: text; - user-select: text; + .user-select(text); } } From 97d737c79939dea514816a31300f7b7b585e2030 Mon Sep 17 00:00:00 2001 From: Jeffrey Fisher Date: Thu, 9 May 2013 19:41:41 -0700 Subject: [PATCH 2/2] Fix code review issues. --- .../default/WebPlatformDocs/WebPlatformDocs.less | 7 ++++++- src/styles/brackets_mixins.less | 3 ++- 2 files changed, 8 insertions(+), 2 deletions(-) diff --git a/src/extensions/default/WebPlatformDocs/WebPlatformDocs.less b/src/extensions/default/WebPlatformDocs/WebPlatformDocs.less index a45bbdb9075..154a1d8c505 100644 --- a/src/extensions/default/WebPlatformDocs/WebPlatformDocs.less +++ b/src/extensions/default/WebPlatformDocs/WebPlatformDocs.less @@ -16,7 +16,12 @@ /* Enable text selection */ cursor: auto; - .user-select(text); + -webkit-user-select: text; + -khtml-user-select: text; + -moz-user-select: text; + -ms-user-select: text; + -o-user-select: text; + user-select: text; &:focus { outline: none; diff --git a/src/styles/brackets_mixins.less b/src/styles/brackets_mixins.less index 89574a8ddbd..c71f1bc2565 100644 --- a/src/styles/brackets_mixins.less +++ b/src/styles/brackets_mixins.less @@ -127,4 +127,5 @@ -ms-user-select: @type; -o-user-select: @type; user-select: @type; -} \ No newline at end of file +} +