Initial implementation of modules #45
Conversation
|
Should we consider following this http://requirejs.org/docs/jquery.html for using jQuery with modules? |
| }; | ||
|
|
||
| // Define public API | ||
| // TODO: Once KeyMap is moved into separate module, export KeyBindingManager methods instead of the entire object |
There was a problem hiding this comment.
Just to make sure I understand this right: if we made KeyMap an "inner class" of KeyBindingManager, then this wouldn't be an issue, right? We'd assign public members of KeyBindingManager directly to the exports object, and one of those members would happen to be the KeyMap ctor?
There was a problem hiding this comment.
Yes, we could do that (export the KeyMap ctor as a public property of KeyBindingManager), or we could make KeyMap a separate module. Either one would be fine.
|
(In reply to Jason's comment above): The require-jquery file is a combination of require.js and jquery.js. They say that they regularly integrate jQuery, but we would be at the mercy of require.js to make sure our jQuery is up to date. I figured it was safest just to keep them separate. |
|
Looks good to me -- merging now. |
Initial implementation of modules
Fix adobe#45 Removed unneccessary connection messages
Fix adobe#45 Removed unneccessary connection messages
Fix adobe#45 Removed unneccessary connection messages
Fix adobe#45 Removed unneccessary connection messages
Fix adobe#45 Removed unneccessary connection messages
Fix adobe#45 Removed unneccessary connection messages
Fix adobe#45 Removed unneccessary connection messages
This is a first pass at modularizing Brackets source code. When viewing the diffs, you probably want to add "?w=1" to the end of the URL to ignore white space.
Here is a link to the diff without whitespace: https://github.com/adobe/brackets/pull/45/files?w=1