This repository has been archived by the owner on Sep 6, 2021. It is now read-only.
Fix for issue #6452: Prevent reload commands from being repeated too quickly #6846
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
|
|
||
| /** @type {boolean} prevents reentrancy of browserReload() */ | ||
| var isReloading = false; |
There was a problem hiding this comment.
Nit: prefix with _ to indicate private variable in this module and move this variable declaration next to other module variables. I know you only need this for the browserReload function, but we would like to have some best practices to group all variables in one section rather than scattering in the module.
|
Done with review. Just have one minor nit. |
|
@RaymondLim, code review update committed. |
RaymondLim
added a commit
that referenced
this pull request
Feb 12, 2014
Fix for issue #6452: Prevent reload commands from being repeated too quickly
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for issue #6452: Prevent reload commands from being repeated too quickly.