New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sort languages via their display names #7593

Merged
merged 3 commits into from Apr 23, 2014

Conversation

Projects
None yet
5 participants
@MarcelGerber
Contributor

MarcelGerber commented Apr 21, 2014

This fixes #7516.

@redmunds

This comment has been minimized.

Show comment
Hide comment
@redmunds

redmunds Apr 22, 2014

Contributor

Is there a reason that italiano, norsk, polski, and suomi are not capitalized?

Contributor

redmunds commented Apr 22, 2014

Is there a reason that italiano, norsk, polski, and suomi are not capitalized?

@TomMalbran

This comment has been minimized.

Show comment
Hide comment
@TomMalbran

TomMalbran Apr 22, 2014

Contributor

I think that English should be sorted to, so that we have English (US) and English (UK) together.

Contributor

TomMalbran commented Apr 22, 2014

I think that English should be sorted to, so that we have English (US) and English (UK) together.

@MarcelGerber

This comment has been minimized.

Show comment
Hide comment
@MarcelGerber

MarcelGerber Apr 23, 2014

Contributor

@redmunds Looks like it's intended to do so - take a look at https://www.google.com/preferences#languages.

@TomMalbran Don't know what to do here, and English (UK) does not yet much in Brackets (basically nothing...).

Contributor

MarcelGerber commented Apr 23, 2014

@redmunds Looks like it's intended to do so - take a look at https://www.google.com/preferences#languages.

@TomMalbran Don't know what to do here, and English (UK) does not yet much in Brackets (basically nothing...).

@redmunds

This comment has been minimized.

Show comment
Hide comment
@redmunds

redmunds Apr 23, 2014

Contributor

@SAPlayer

Looks like it's intended to do so - take a look at https://www.google.com/preferences#languages.

I don't think that's a good example, since some of the ones that we have capitalized are lowercase there. It's not really related to this change, so we don't need to worry about it.

Contributor

redmunds commented Apr 23, 2014

@SAPlayer

Looks like it's intended to do so - take a look at https://www.google.com/preferences#languages.

I don't think that's a good example, since some of the ones that we have capitalized are lowercase there. It's not really related to this change, so we don't need to worry about it.

@MarcelGerber

This comment has been minimized.

Show comment
Hide comment
@MarcelGerber

MarcelGerber Apr 23, 2014

Contributor

@redmunds Changes pushed. We should consider looking at the locale names a second time, Google and Wikipedia state other names sometimes (or other casing). I could do that if you want.

Contributor

MarcelGerber commented Apr 23, 2014

@redmunds Changes pushed. We should consider looking at the locale names a second time, Google and Wikipedia state other names sometimes (or other casing). I could do that if you want.

@redmunds

This comment has been minimized.

Show comment
Hide comment
@redmunds

redmunds Apr 23, 2014

Contributor

@TomMalbran

I think that English should be sorted to, so that we have English (US) and English (UK) together.

This dialog was designed to help those translating from English (US) to some other language, so that's why it was placed at the top. This PR is about ordering the other items in the list, so we'll just keep it there for now.

Contributor

redmunds commented Apr 23, 2014

@TomMalbran

I think that English should be sorted to, so that we have English (US) and English (UK) together.

This dialog was designed to help those translating from English (US) to some other language, so that's why it was placed at the top. This PR is about ordering the other items in the list, so we'll just keep it there for now.

@redmunds

This comment has been minimized.

Show comment
Hide comment
@redmunds

redmunds Apr 23, 2014

Contributor

Looks good. Merging.

Contributor

redmunds commented Apr 23, 2014

Looks good. Merging.

redmunds added a commit that referenced this pull request Apr 23, 2014

Merge pull request #7593 from SAPlayer/fix-7516
Sort languages via their display names

@redmunds redmunds merged commit 4a61749 into adobe:master Apr 23, 2014

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details

@MarcelGerber MarcelGerber deleted the MarcelGerber:fix-7516 branch Apr 23, 2014

@TomMalbran

This comment has been minimized.

Show comment
Hide comment
@TomMalbran

TomMalbran Apr 23, 2014

Contributor

In that case, we could place the other English locales at the top too?

Contributor

TomMalbran commented Apr 23, 2014

In that case, we could place the other English locales at the top too?

@MarcelGerber

This comment has been minimized.

Show comment
Hide comment
@MarcelGerber

MarcelGerber Apr 23, 2014

Contributor

Well, at least for now English (UK) doesn't differ from English (US) in core. It would be nice to see them beneath each other, but that would possibly require hardcoding en-gb to the top, which isn't the best.

Contributor

MarcelGerber commented Apr 23, 2014

Well, at least for now English (UK) doesn't differ from English (US) in core. It would be nice to see them beneath each other, but that would possibly require hardcoding en-gb to the top, which isn't the best.

@peterflynn

This comment has been minimized.

Show comment
Hide comment
@peterflynn

peterflynn Apr 24, 2014

Member

@TomMalbran @SAPlayer Actually, do you know why we bother forcing "English (US)" to the top of the list? From a user standpoint, there's nothing special about "English (US)" -- users don't care that it's the "root" language under the hood... (But of course I can see why we'd want "System Default" at the top -- definitely not suggesting changing that).

Member

peterflynn commented Apr 24, 2014

@TomMalbran @SAPlayer Actually, do you know why we bother forcing "English (US)" to the top of the list? From a user standpoint, there's nothing special about "English (US)" -- users don't care that it's the "root" language under the hood... (But of course I can see why we'd want "System Default" at the top -- definitely not suggesting changing that).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment