New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix update notification for not localized languages #7811

Merged
merged 1 commit into from May 11, 2014

Conversation

Projects
None yet
2 participants
@MarcelGerber
Contributor

MarcelGerber commented May 10, 2014

This fixes #7810.

@ingorichter ingorichter self-assigned this May 11, 2014

@ingorichter

This comment has been minimized.

Show comment
Hide comment
@ingorichter

ingorichter May 11, 2014

Contributor

That fixes the problem. It's too late now, but there is something wrong with the unit tests, since I was never able to reproduce the behavior that I saw (the always handler being called). I might have overlooked something when mocking $.ajax. I assume, that there is something missing to trigger the always handler.

Contributor

ingorichter commented May 11, 2014

That fixes the problem. It's too late now, but there is something wrong with the unit tests, since I was never able to reproduce the behavior that I saw (the always handler being called). I might have overlooked something when mocking $.ajax. I assume, that there is something missing to trigger the always handler.

ingorichter added a commit that referenced this pull request May 11, 2014

Merge pull request #7811 from SAPlayer/fix-update-notification
Fix update notification for not localized languages

@ingorichter ingorichter merged commit d4e67c3 into adobe:release May 11, 2014

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details

@MarcelGerber MarcelGerber deleted the MarcelGerber:fix-update-notification branch May 11, 2014

@MarcelGerber

This comment has been minimized.

Show comment
Hide comment
@MarcelGerber

MarcelGerber May 11, 2014

Contributor

@ingorichter I debugged the test a bit and saw that, for some reason, it's running synchronous.
I.e. the inner always is called before the outer one is called.

Contributor

MarcelGerber commented May 11, 2014

@ingorichter I debugged the test a bit and saw that, for some reason, it's running synchronous.
I.e. the inner always is called before the outer one is called.

@ingorichter

This comment has been minimized.

Show comment
Hide comment
@ingorichter

ingorichter May 11, 2014

Contributor

@SAPlayer Which would explain why the tests didn't catch this issue. I wonder what is wrong with the tests. Perhaps the way I'm mocking the ajax call is plainly wrong.

Contributor

ingorichter commented May 11, 2014

@SAPlayer Which would explain why the tests didn't catch this issue. I wonder what is wrong with the tests. Perhaps the way I'm mocking the ajax call is plainly wrong.

@MarcelGerber

This comment has been minimized.

Show comment
Hide comment
@MarcelGerber

MarcelGerber May 11, 2014

Contributor

@ingorichter Fix for the tests is up.

Contributor

MarcelGerber commented May 11, 2014

@ingorichter Fix for the tests is up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment