some tests to clarify what convertToNativePath does. Issue #3872 #7957

Merged
merged 1 commit into from Aug 26, 2014

Projects

None yet

3 participants

@chirayu11
Contributor

I have added some tests as a start to clarify what convertToNativePath is doing. I can rename the method (should I copy it and deprecate the old one?).
#3872

@ingorichter
Contributor

@chirayu11 Thank you very much for the contribution. Currently the build fails because of code formatting issues. Please have a look at the Travis CI link above. Travis is running JSHint on the source code. You can do the same from inside the brackets directory by running grunt jshint. This will show you any issues. Thanks.

@ingorichter ingorichter merged commit 3698e76 into adobe:master Aug 26, 2014

1 check failed

continuous-integration/travis-ci The Travis CI build failed
Details
@ingorichter
Contributor

Created new PR to fix the formatting issues. Thanks for the contribution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment