From 1c820e1282449e4f5345ba2c19e28870cb1eab2d Mon Sep 17 00:00:00 2001 From: Narciso Jaramillo Date: Fri, 20 Jun 2014 11:34:09 -0700 Subject: [PATCH] Turn off click-to-rename for folders to address #8200 --- src/project/ProjectManager.js | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/project/ProjectManager.js b/src/project/ProjectManager.js index 94b715c7a44..709783a75cb 100644 --- a/src/project/ProjectManager.js +++ b/src/project/ProjectManager.js @@ -668,8 +668,10 @@ define(function (require, exports, module) { return; } - var $treenode = $(event.target).closest("li"); - if ($treenode.is($(_projectTree.jstree("get_selected")))) { + var $treenode = $(event.target).closest("li"), + entry = $treenode.data("entry"); + // Don't do the rename for folders, because clicking on a folder name collapses/expands it. + if (entry && entry.isFile && $treenode.is($(_projectTree.jstree("get_selected")))) { // wrap this in a setTimeout function so that we can check if it's a double click. _mouseupTimeoutId = window.setTimeout(function () { // if we get a double-click, _mouseupTimeoutId will have been set to null by the double-click handler before this runs.