New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #8273: "sortDirectoriesFirst": true in .brackets.json not always working properly #8341

Merged
merged 1 commit into from Jul 16, 2014

Conversation

Projects
None yet
2 participants
@TomMalbran
Contributor

TomMalbran commented Jul 8, 2014

The issue is that when using locale compare to compare the filenames, we turn the numeric option to on, so that "1" < "2" < "10". This was done so that we get Undefined-1, Undefined-2, Undefined-3, Undefined-10, instead of Undefined-1, Undefined-10, Undefined-2, Undefined-3. But this break the file sorting, since we preppend a 0 to folders and a 1 to files. So later we have that "1XX" < "002", where the first is a file and the second a folder. By changing the prefixes to letters, we can fix this.

This is for #8273.

@redmunds

This comment has been minimized.

Show comment
Hide comment
@redmunds

redmunds Jul 15, 2014

Contributor

Triage Complete.

Contributor

redmunds commented Jul 15, 2014

Triage Complete.

@redmunds

This comment has been minimized.

Show comment
Hide comment
@redmunds

redmunds Jul 16, 2014

Contributor

Surprised that this was reported on Mac before Windows. Thanks. Merging.

Contributor

redmunds commented Jul 16, 2014

Surprised that this was reported on Mac before Windows. Thanks. Merging.

redmunds added a commit that referenced this pull request Jul 16, 2014

Merge pull request #8341 from adobe/tom/fix-dirs-first
Fix #8273: "sortDirectoriesFirst": true in .brackets.json not always working properly

@redmunds redmunds merged commit 21cf9a9 into master Jul 16, 2014

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details

@redmunds redmunds deleted the tom/fix-dirs-first branch Jul 16, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment